Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teams: clarify behavior of split ops with strides <= 0 #519

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

davidozog
Copy link
Collaborator

Summary of changes

This addresses #491 by clarifying the behavior of team split operations when stride is zero or negative.

Proposal Checklist

  • Link to issue(s)
  • Changelog entry
  • Reviewed for changes to front matter
  • Reviewed for changes to back matter

@davidozog davidozog added this to the OpenSHMEM 1.6 milestone Jul 11, 2024
@davidozog davidozog self-assigned this Jul 11, 2024
@jdinan
Copy link
Collaborator

jdinan commented Aug 22, 2024

@davidozog Start description needs to be changed in order to allow negative strides:

\apiargument{IN}{start}{The lowest \ac{PE} number of the subset of \acp{PE} from
the parent team that will form the new team.}

With a negative stride, start is no longer the lowest PE index of the members in the parent team.

@davidozog
Copy link
Collaborator Author

@davidozog Start description needs to be changed in order to allow negative strides...

Agreed!

How about "the first" PE number...? Any suggestions on how to handle this fix?

@jdinan
Copy link
Collaborator

jdinan commented Aug 22, 2024

I can't see a small edit that will make this clear. I'd suggest another sentence or two to explain it clearly.

@jdinan
Copy link
Collaborator

jdinan commented Aug 23, 2024

Adding a note that "lowest" is doing some work here by forbidding "wrap-arounds". The updated text should specify "lowest/highest".

@jdinan jdinan merged commit 2592c49 into openshmem-org:master Aug 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Teams and Ctx (9.4-9.5)
Development

Successfully merging this pull request may close these issues.

2 participants