Fix shmem_team_split_strided's start argument wording.
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidozog
approved these changes
Aug 29, 2024
davidozog
added a commit
to davidozog/openshmem-specification
that referenced
this pull request
Aug 30, 2024
The fix to "start" is covered in a different PR: wokuno#1
wokuno
reviewed
Aug 30, 2024
wokuno
approved these changes
Aug 30, 2024
davidozog
approved these changes
Aug 30, 2024
wokuno
approved these changes
Aug 31, 2024
4 tasks
wokuno
pushed a commit
that referenced
this pull request
Oct 3, 2024
[SHMEM 1.6 Sec 10] Minor grammatical edits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR fixes the wording of
shmem_team_split_strided'sstartargument for non-positive value.I think the entry in the backmatter still covers this but let me know if we need to tweak it as well:
https://github.com/davidozog/openshmem-specification/blob/a392d409d6dd3d94f6685eaf9fe5941bb0e40c8d/content/backmatter.tex#L706-L708
Relevant PRs are:
Proposal Checklist