-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run release time FTR tests on PR runs #1941
Run release time FTR tests on PR runs #1941
Conversation
Signed-off-by: Derek Ho <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1941 +/- ##
=======================================
Coverage 70.61% 70.61%
=======================================
Files 97 97
Lines 2600 2600
Branches 380 387 +7
=======================================
Hits 1836 1836
Misses 668 668
Partials 96 96 ☔ View full report in Codecov by Sentry. |
Seems like it is getting stuck on permissions spec, going to check that right now, specifically: should open modal with options to create new action group page |
Looks like it may just be timing out I need to double check this |
Blocked on: opensearch-project/OpenSearch-Dashboards#7154 |
The fix for the above issue is here: opensearch-project/OpenSearch-Dashboards#7163 |
Fix got merged, and re-running all the CI jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in this commit are causing the tests to fail: opensearch-project/opensearch-dashboards-functional-test@6cba7a6
this PR should fix cypress test failure: opensearch-project/opensearch-dashboards-functional-test#1439 and unblock CI |
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Description
This PR adds running all the associated FTR tests on every PR getting merged into the security dashboards plugin. This will raise awareness of the implicit connection here, and also let contributors know when their change needs to make a corresponding test in the FTR, instead of waiting until release time to figure this out.
Category
Enhancement
Why these changes are required?
Fix: #1936
What is the old behavior before changes and new behavior after changes?
Before: not all FTR tests were being run
After: now, all tests run during release time are run with every raised PR
Issues Resolved
Close: #1936
Testing
Existing tests pass
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.