Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run release time FTR tests on PR runs #1941

Merged
merged 11 commits into from
Jul 17, 2024

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented May 8, 2024

Description

This PR adds running all the associated FTR tests on every PR getting merged into the security dashboards plugin. This will raise awareness of the implicit connection here, and also let contributors know when their change needs to make a corresponding test in the FTR, instead of waiting until release time to figure this out.

Category

Enhancement

Why these changes are required?

Fix: #1936

What is the old behavior before changes and new behavior after changes?

Before: not all FTR tests were being run
After: now, all tests run during release time are run with every raised PR

Issues Resolved

Close: #1936

Testing

Existing tests pass

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.61%. Comparing base (757f4ce) to head (0c7992e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1941   +/-   ##
=======================================
  Coverage   70.61%   70.61%           
=======================================
  Files          97       97           
  Lines        2600     2600           
  Branches      380      387    +7     
=======================================
  Hits         1836     1836           
  Misses        668      668           
  Partials       96       96           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derek-ho
Copy link
Collaborator Author

derek-ho commented May 20, 2024

Seems like it is getting stuck on permissions spec, going to check that right now, specifically: should open modal with options to create new action group page

@derek-ho
Copy link
Collaborator Author

Looks like it may just be timing out I need to double check this

@derek-ho derek-ho marked this pull request as ready for review June 19, 2024 17:33
@derek-ho
Copy link
Collaborator Author

RyanL1997
RyanL1997 previously approved these changes Jun 19, 2024
@derek-ho
Copy link
Collaborator Author

derek-ho commented Jul 2, 2024

@RyanL1997
Copy link
Collaborator

The fix for the above issue is here: opensearch-project/OpenSearch-Dashboards#7163

@RyanL1997
Copy link
Collaborator

Fix got merged, and re-running all the CI jobs

@cwperks
Copy link
Member

cwperks commented Jul 5, 2024

@derek-ho do we need to complete #2005 and associated reversion in FTR to avoid this state where main shows one label and 2.x shows a separate label?

Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this commit are causing the tests to fail: opensearch-project/opensearch-dashboards-functional-test@6cba7a6

@DarshitChanpura
Copy link
Member

this PR should fix cypress test failure: opensearch-project/opensearch-dashboards-functional-test#1439 and unblock CI

@derek-ho derek-ho merged commit 2e53b3c into opensearch-project:main Jul 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Run or transfer full FTR tests to security dashboards plugin repo
5 participants