Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the span item to reflect correct text #1439

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

DarshitChanpura
Copy link
Member

Description

Create user account text doesn't exist on internal-users page. Replaced it with correct text Create internal user

Issues Resolved

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@DarshitChanpura
Copy link
Member Author

DarshitChanpura commented Jul 9, 2024

Cypress tests are failing due to stale distribution image.
@derek-ho has a PR out to fix this: opensearch-project/opensearch-build#4468

We have been seeing auto-cut failures for 3.0.0 distribution build and are investigating it opensearch-project/security-dashboards-plugin#1786 and the root-cause for the failures is (file-link):

ERROR [single_version_dependencies] Multiple version ranges for the same dependency
      were found declared across different package.json files. Please consolidate
      those to match across all package.json files. Different versions for the
      same dependency is not supported.

      If you have questions about this please reach out to the operations team.

      The conflicting dependencies are:

        cypress
          9.5.4 => opensearch-dashboards
          ^13.6.0 => opensearch-security-dashboards
error Command failed with exit code 1.

Meanwhile, @peterzhuamazon @gaiksaya any thoughts on how to get this unblocked?

@DarshitChanpura
Copy link
Member Author

@tianleh @kavilla @ohltyler @CCongWang Could I get some reviews on this PR? This PR will unblock a PR in security. Thanks in advance!

Signed-off-by: Darshit Chanpura <[email protected]>
@derek-ho
Copy link
Contributor

We should also backport this to 2.x

@yujin-emma yujin-emma merged commit c6eeff6 into opensearch-project:main Jul 16, 2024
39 checks passed
@DarshitChanpura
Copy link
Member Author

We should also backport this to 2.x

No need. Changes are already present in 2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants