add completionCount constants for co-ordinator and shard level tasks #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… backpressure stats Signed-off-by: Kaushal Kumar <[email protected]>
kaushalmahi12
requested review from
praveensameneni,
khushbr,
ansjcy,
goyamegh,
getsaurabh02,
sbcd90 and
sgup432
as code owners
ansjcy
previously approved these changes
Nov 13, 2023
|
LGTM. |
sgup432
reviewed
Nov 20, 2023
src/main/java/org/opensearch/performanceanalyzer/commons/metrics/AllMetrics.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kaushal Kumar <[email protected]>
ansjcy
reviewed
Dec 4, 2023
src/main/java/org/opensearch/performanceanalyzer/commons/metrics/AllMetrics.java
Show resolved
Hide resolved
|
LGTM apart from the minor nit |
ansjcy
approved these changes
Dec 8, 2023
deshsidd
approved these changes
Dec 13, 2023
sgup432
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
completionCountmetrics constants. This was previously not part of/stats/search_backpressureAPI as the change got merged post 2.11 release. We will need this metric to find correct cancellation percentage with respect to total completed tasks at shard and co-ordinator level.Github issue: opensearch-project/performance-analyzer#587
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you are proposing
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.