Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add completion count into shard level and task level SBP RCA #517

Merged
merged 9 commits into from
Dec 22, 2023

Conversation

kaushalmahi12
Copy link
Contributor

@kaushalmahi12 kaushalmahi12 commented Nov 10, 2023

Related PRs

github issue: opensearch-project/performance-analyzer#587

Changing logic to take completionCount into account at shard and task level to accurately calculate the SBP RCAs.

2023-11-10 06:44:40.893 [PA:Reader] [9449wUCJQp2jb7FYh7CmAw-task-0-] INFO  org.opensearch.performanceanalyzer.plugins.PublisherEventsLogger - Action: [SearchBackPressureAction] published by decision maker publisher. action summary : {"thresholdName":"heap_usage","searchbpDimension":"shard","direction":"decrease","stepSizeInPercentage":5.0,"coolOffPeriodInMillis":86400000,"canUpdate":true}

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you are proposing
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • Backport Labels added.
  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

config/rca.conf Outdated Show resolved Hide resolved
@deshsidd
Copy link

deshsidd commented Dec 5, 2023

There are some build errors related to syntax. Please fix and try to build locally

Signed-off-by: Kaushal Kumar <[email protected]>
ansjcy
ansjcy previously approved these changes Dec 8, 2023
ansjcy
ansjcy previously approved these changes Dec 12, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (30ca0b3) 74.39% compared to head (3169f74) 74.43%.
Report is 3 commits behind head on main.

Files Patch % Lines
...h/performanceanalyzer/LocalhostConnectionUtil.java 60.71% 11 Missing ⚠️
...s/searchbackpressure/SearchBackPressurePolicy.java 0.00% 7 Missing ⚠️
.../rca/searchbackpressure/SearchBackPressureRCA.java 75.86% 5 Missing and 2 partials ⚠️
...lyzer/rca/configs/SearchBackPressureRcaConfig.java 0.00% 6 Missing ⚠️
...ckpressure/model/SearchBackPressureShardIssue.java 0.00% 5 Missing ⚠️
...ackpressure/model/SearchBackPressureRCAMetric.java 75.00% 0 Missing and 2 partials ⚠️
...ecisionmaker/actions/SearchBackPressureAction.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #517      +/-   ##
============================================
+ Coverage     74.39%   74.43%   +0.03%     
- Complexity     2662     2666       +4     
============================================
  Files           317      317              
  Lines         16298    16378      +80     
  Branches       1277     1282       +5     
============================================
+ Hits          12125    12191      +66     
- Misses         3659     3671      +12     
- Partials        514      516       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sgup432 sgup432 merged commit 70222ba into opensearch-project:main Dec 22, 2023
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants