-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the incorrect location of pkg build_templates #4539
Fix the incorrect location of pkg build_templates #4539
Conversation
Signed-off-by: Peter Zhu <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4539 +/- ##
=======================================
Coverage 92.17% 92.17%
=======================================
Files 192 192
Lines 6297 6297
=======================================
Hits 5804 5804
Misses 493 493 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible can you add tests for this? A simple change but looks like breaking one if scripts are moved in the future.
I will create an issue for the |
We can expand on this old issue: Thanks. |
…#4539) Signed-off-by: Peter Zhu <[email protected]>
Description
Fix the incorrect location of pkg build_templates
Issues Resolved
#3815
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.