Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the incorrect location of pkg build_templates #4539

Conversation

peterzhuamazon
Copy link
Member

Description

Fix the incorrect location of pkg build_templates

Issues Resolved

#3815

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.17%. Comparing base (cf8508d) to head (200b430).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4539   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files         192      192           
  Lines        6297     6297           
=======================================
  Hits         5804     5804           
  Misses        493      493           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible can you add tests for this? A simple change but looks like breaking one if scripts are moved in the future.

@peterzhuamazon
Copy link
Member Author

If possible can you add tests for this? A simple change but looks like breaking one if scripts are moved in the future.

I will create an issue for the scripts dir in general, none of them have proper testing for now.

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Mar 18, 2024

We can expand on this old issue:

Thanks.

@peterzhuamazon peterzhuamazon merged commit 14c35b6 into opensearch-project:main Mar 18, 2024
13 checks passed
@peterzhuamazon peterzhuamazon deleted the fix-pkg-2.13-build-templates-location branch March 18, 2024 22:16
Divyaasm pushed a commit to Divyaasm/opensearch-build that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants