[Meta] Improve Deb/Rpm OpenSearch packaging in 2.x Releases

[smortex]

Context

OpenSearch / OpenSearch Dashboard packages can be improved in several areas. Some of these improvements can arguably be considered breaking changes because they may somewhat disrupt users workflow. This PR is intended to aggregate the packaging improvement progress, see where we are and what are the next moves.

Progress

• Announce upcoming breaking changes in packaging #4051 (🚢 in 2.10.0)
• Defaut config permission too relaxed in deb and rpm packages #3815 (🚢 in 2.13.0)
  • Improve ownership and permissions of files in OpenSearch deb and rpm packages #3898 (reverted)
  • Improve ownership and permissions of files in OpenSearch-Dashboards deb and rpm packages #3952 (reverted)
  • Fix opensearch-dashboard user's permission to allow reading the service configuration files #4038 (reverted)
  • Reset deb rpm permissions to original state #4041
  • Switch all active CI Docker Images to use ci-runner username for 1000 uid #4191
  • [Resume] Improve ownership and permissions of files in OpenSearch/Dashboards deb and rpm packages #4043
  • Support new deb/rpm permissions changes in #4043 on integTest #4534
  • Allow 1.x deb/rpm to use the old build templates #4536
  • Fix the incorrect location of pkg build_templates #4539
  • Allow current user to join os/osd group during deb/rpm test  #4548
  • Add current user to adm group to access logs #4553
  • Cleanup deb/rpm integTest uninstallation properly #4557
• Debian(RPM later): Restart OpenSearch/Dashboards Service after Upgrading the Package #3891 (🚢 in 2.13.0)
  • Automatic Service Restart when Service is Enabled (Debian) #4530
• [Bug]: Configuration files overwritten when updating .rpm package #4084 (🚢 in 2.14.0)
  • Make sure opensearch rpm config folders configs preserve on updates #4665
• Misc
  • debian package: improve wording in postinst script #3109
  • Improve DEB post install and uninstall scripts with abstractions #4240 (⌛ Revisit in the next major release Meta Issue)
    • Proposal: Improve Debian package quality and compatibility across debian-based distributions by using proper debhelper scripts and respecting the debian packaging policy #4243
  • Remove spurious SGID bit on directories OpenSearch#9447
  • [BUG] Deb assemble does not correctly show found deb artifact #4532

[automaticserver]

The postinst Script inside opensearch package has several problems. First it doesn't use the right abstraction tools. Never use "systemctl" or "service" or whatever directly to interact with the init system. For good reasons there are abstractions to handle implementation details of the currrent init system.

Please use:

• invoke-rc.d to start/stop/restart service
• update-rc.d to enable/disable a service

https://www.debian.org/doc/debian-policy/ch-opersys.html#running-init-scripts

They does always the RIGHT thing, even if a system administrator changes his init system. You can rely on them and save code inside postinst.

[peterzhuamazon]

The postinst Script inside opensearch package has several problems. First it doesn't use the right abstraction tools. Never use "systemctl" or "service" or whatever directly to interact with the init system. For good reasons there are abstractions to handle implementation details of the currrent init system.

Please use:

* invoke-rc.d to start/stop/restart service

* update-rc.d to enable/disable a service

https://www.debian.org/doc/debian-policy/ch-opersys.html#running-init-scripts

They does always the RIGHT thing, even if a system administrator changes his init system. You can rely on them and save code inside postinst.

That is a good callout @automaticserver we will look into those abstractions.
Thanks.

[automaticserver]

Please have a look at my newly created proposal: #4243. E.g. there would be no need to implicitly use the abstractions as debhelper would generate those parts in the maintainer script the correct way automatically.

/dm

[peterzhuamazon]

We will close the bugs related to 2.x, and will move some issues to track in the next possible major version.

[peterzhuamazon]

A new meta issue for the next major version release will be created later.

[peterzhuamazon]

Closing for now.