Announce upcoming breaking changes in packaging #4051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In opensearch-project#4043, we will introduce changes that might impact users. Add a note at installation time to warn them about this future change and how to proceed to not have trouble if they will be affected by the change. Signed-off-by: Romain Tartière <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4051 +/- ##
=======================================
Coverage 92.10% 92.10%
=======================================
Files 187 187
Lines 5677 5677
=======================================
Hits 5229 5229
Misses 448 448 |
smortex
requested review from
dblock,
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
scripts/pkg/build_templates/opensearch-dashboards/deb/debian/postinst
Outdated
Show resolved
Hide resolved
This will not be backported to 1.x packages, but since 1.x and 2.x currently share the tooling, add information so that users are not confused. As users of 1.x are expected to switch to a newer version at some point, include the informational message for them to prepare the sooner. Signed-off-by: Romain Tartière <[email protected]>
|
I added a commit that try to make this more clear as you suggested in slack. Maybe native English speaker will be able to help us to make this more straightforward? The commit message has more details, but I think we deserve something concise as a post-installation message. |
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
force-pushed
the
announce-future-breaking-change
branch
from
0564b07
to
a3de249
Compare
Signed-off-by: Peter Zhu <[email protected]>
|
Hi @smortex Updated PR with some wording improvements. |
|
👍 Excellent! LGTM! |
gaiksaya
approved these changes
Sep 20, 2023
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4043, we will introduce changes that might impact users. Add a note at installation time to warn them about this future change and how to proceed to not have trouble if they will be affected by the change.