Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved UI_METADATA from state to GC index and excluded it from search … #156

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

owaiskazi19
Copy link
Member

Description

  1. Moved UI_METADATA from state to GC index
  2. Excluded UI_METADATA from search response for now
  3. Created Builder for Template Model

Issues Resolved

Closes #140

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #156 (a0edf68) into main (56ccb1d) will increase coverage by 2.73%.
Report is 1 commits behind head on main.
The diff coverage is 89.94%.

@@             Coverage Diff              @@
##               main     #156      +/-   ##
============================================
+ Coverage     68.39%   71.12%   +2.73%     
- Complexity      339      368      +29     
============================================
  Files            45       47       +2     
  Lines          1585     1728     +143     
  Branches        143      154      +11     
============================================
+ Hits           1084     1229     +145     
+ Misses          452      443       -9     
- Partials         49       56       +7     
Files Coverage Δ
...g/opensearch/flowframework/common/CommonValue.java 100.00% <ø> (ø)
...ework/transport/CreateWorkflowTransportAction.java 58.76% <100.00%> (+0.42%) ⬆️
...nsearch/flowframework/workflow/ModelGroupStep.java 88.67% <100.00%> (ø)
...ch/flowframework/workflow/WorkflowStepFactory.java 100.00% <100.00%> (ø)
...framework/indices/FlowFrameworkIndicesHandler.java 29.18% <0.00%> (ø)
.../opensearch/flowframework/model/WorkflowState.java 0.00% <0.00%> (ø)
...pensearch/flowframework/util/RestHandlerUtils.java 0.00% <0.00%> (ø)
...ensearch/flowframework/workflow/GetMLTaskStep.java 92.85% <92.85%> (ø)
...lowframework/workflow/RegisterRemoteModelStep.java 88.23% <86.95%> (ø)
...a/org/opensearch/flowframework/model/Template.java 89.58% <92.15%> (+0.22%) ⬆️
... and 1 more

Copy link
Member

@joshpalis joshpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a comment

@owaiskazi19 owaiskazi19 merged commit cdb8c68 into opensearch-project:main Nov 13, 2023
21 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 13, 2023
#156)

Moved UI_METADATA from state to GC index and excluded it from search response

Signed-off-by: Owais Kazi <[email protected]>
(cherry picked from commit cdb8c68)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
owaiskazi19 pushed a commit that referenced this pull request Nov 13, 2023
…it from search … (#163)

Moved UI_METADATA from state to GC index and excluded it from search … (#156)

Moved UI_METADATA from state to GC index and excluded it from search response


(cherry picked from commit cdb8c68)

Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Move UI Metadata from State Index to Global Context Index
3 participants