Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Workflow Parsing fails with another Map Object #157

Closed
owaiskazi19 opened this issue Nov 10, 2023 · 2 comments
Closed

[BUG] Workflow Parsing fails with another Map Object #157

owaiskazi19 opened this issue Nov 10, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@owaiskazi19
Copy link
Member

What is the bug?

With the new addition to Template Model, UI_METADATA field. The parser for workflow treats ui_metdata field as another workflow item.

https://github.com/opensearch-project/opensearch-ai-flow-framework/blob/1de0ca54ab29c00987f56e982c87855b70e47911/src/main/java/org/opensearch/flowframework/model/Template.java#L164-L169

How can one reproduce the bug?

Steps to reproduce the behavior.

  1. Add a new map object similar to Moved UI_METADATA from state to GC index and excluded it from search … #156 and run tests.
REPRODUCE WITH: ./gradlew ':test' --tests "org.opensearch.flowframework.model.TemplateTests.testTemplate" -Dtests.seed=11B7CC6871F9718B -Dtests.security.manager=false -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=th-TH-u-nu-thai-x-lvariant-TH -Dtests.timezone=Pacific/Samoa -Druntime.java=14

org.opensearch.flowframework.model.TemplateTests > testTemplate FAILED
    java.io.IOException: A workflow must have at least one node.
        at __randomizedtesting.SeedInfo.seed([11B7CC6871F9718B:5B2B768F27CFA470]:0)
        at org.opensearch.flowframework.model.Workflow.parse(Workflow.java:120)
        at org.opensearch.flowframework.model.Template.parse(Template.java:299)
        at org.opensearch.flowframework.model.Template.parse(Template.java:341)
        at org.opensearch.flowframework.model.TemplateTests.testTemplate(TemplateTests.java:63)

What is the expected behavior?

Parsing should pass

What is your host/environment?

MacOS

Do you have any screenshots?

Screenshot 2023-11-09 at 11 26 06 AM

Do you have any additional context?

Add any other context about the problem.

@owaiskazi19 owaiskazi19 added bug Something isn't working untriaged labels Nov 10, 2023
@dbwiddis
Copy link
Member

dbwiddis commented Jan 8, 2024

Is this still an issue or can it be closed?

@minalsha
Copy link
Collaborator

@owaiskazi19 does this issue still persists?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants