Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separates RegisterModelStep into RegisterLocalModelStep and RegisterRemoteModelStep. Adds GetMLTaskStep. Handles optional params #155

Merged
merged 13 commits into from
Nov 13, 2023

moving modelConfig builder before adding allConfig

285eb6f
Select commit
Loading
Failed to load commit list.
Merged

Separates RegisterModelStep into RegisterLocalModelStep and RegisterRemoteModelStep. Adds GetMLTaskStep. Handles optional params #155

moving modelConfig builder before adding allConfig
285eb6f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Nov 10, 2023 in 0s

91.34% of diff hit (target 70.00%)

View this Pull Request on Codecov

91.34% of diff hit (target 70.00%)

Annotations

Check warning on line 338 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L338 

Added line #L338 was not covered by tests

Check warning on line 134 in src/main/java/org/opensearch/flowframework/workflow/RegisterLocalModelStep.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/workflow/RegisterLocalModelStep.java#L133-L134 

Added lines #L133 - L134 were not covered by tests

Check warning on line 161 in src/main/java/org/opensearch/flowframework/workflow/RegisterLocalModelStep.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/workflow/RegisterLocalModelStep.java#L161 

Added line #L161 was not covered by tests

Check warning on line 188 in src/main/java/org/opensearch/flowframework/workflow/RegisterLocalModelStep.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/workflow/RegisterLocalModelStep.java#L188 

Added line #L188 was not covered by tests

Check warning on line 123 in src/main/java/org/opensearch/flowframework/workflow/RegisterRemoteModelStep.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/workflow/RegisterRemoteModelStep.java#L123 

Added line #L123 was not covered by tests
View more details on Codecov