Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separates RegisterModelStep into RegisterLocalModelStep and RegisterRemoteModelStep. Adds GetMLTaskStep. Handles optional params #155

Merged
merged 13 commits into from
Nov 13, 2023

moving modelConfig builder before adding allConfig

285eb6f
Select commit
Loading
Failed to load commit list.
Merged

Separates RegisterModelStep into RegisterLocalModelStep and RegisterRemoteModelStep. Adds GetMLTaskStep. Handles optional params #155

moving modelConfig builder before adding allConfig
285eb6f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 10, 2023 in 1s

69.18% (+1.48%) compared to 1de0ca5

View this Pull Request on Codecov

69.18% (+1.48%) compared to 1de0ca5

Details

Codecov Report

Merging #155 (285eb6f) into main (1de0ca5) will increase coverage by 1.48%.
The diff coverage is 91.34%.

❗ Current head 285eb6f differs from pull request most recent head 4866219. Consider uploading reports for the commit 4866219 to get more accurate results

@@             Coverage Diff              @@
##               main     #155      +/-   ##
============================================
+ Coverage     67.70%   69.18%   +1.48%     
- Complexity      330      349      +19     
============================================
  Files            43       44       +1     
  Lines          1539     1613      +74     
  Branches        142      147       +5     
============================================
+ Hits           1042     1116      +74     
+ Misses          448      446       -2     
- Partials         49       51       +2     
Files Coverage Δ
...g/opensearch/flowframework/common/CommonValue.java 100.00% <ø> (ø)
...owframework/rest/AbstractSearchWorkflowAction.java 67.85% <ø> (ø)
...pensearch/flowframework/util/RestHandlerUtils.java 0.00% <ø> (ø)
...nsearch/flowframework/workflow/ModelGroupStep.java 88.67% <100.00%> (ø)
...ch/flowframework/workflow/WorkflowStepFactory.java 100.00% <100.00%> (ø)
...framework/indices/FlowFrameworkIndicesHandler.java 29.18% <0.00%> (ø)
...lowframework/workflow/RegisterRemoteModelStep.java 90.00% <90.00%> (ø)
...flowframework/workflow/RegisterLocalModelStep.java 92.50% <92.50%> (ø)