Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSearchSink - Enhance logs to include index name and last exception information #4841

Merged
merged 5 commits into from
Sep 27, 2024
Merged

OpenSearchSink - Enhance logs to include index name and last exception information #4841

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a90fd37
dplive1.yaml
kkondaka Jun 21, 2024
0d3ca76
Delete .github/workflows/static.yml
kkondaka Jul 30, 2024
f53475b
OpenSearchSink - Enhance logs to include index name and last exceptio…
Aug 16, 2024
0740967
Rebased to latest and cleanup messages
Aug 16, 2024
0c2a2d2
Fixed test errors
Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...h/src/main/java/org/opensearch/dataprepper/plugins/sink/opensearch/BulkRetryStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ public void execute(final AccumulatingBulkRequest bulkRequest) throws Interrupte
request = operationResponse.getBulkRequest();
exceptionMessage = operationResponse.getExceptionMessage();
if (delayMillis < 0) {
RuntimeException e = new RuntimeException(String.format("Index : %s, Number of retries reached the limit of max retries (configured value %d. Last exception message: %s)", maxRetries, exceptionMessage));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why get rid of the index name here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@graytaylor0 I did not get rid of it. It is not available. I have mistakenly put it there in the previous revision.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Index is available at each operation level. Not at bulk operation level.

RuntimeException e = new RuntimeException(String.format("Number of retries reached the limit of max retries (configured value %d. Last exception message: %s)", maxRetries, exceptionMessage));
handleFailures(request, null, e);
break;
}
Expand Down
Loading