OpenSearchSink - Enhance logs to include index name and last exception information #4841
+14
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkondaka
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
graytaylor0
previously approved these changes
Aug 16, 2024
|
Build and DCO checks are failing |
kkondaka
force-pushed
the
ossink-log-fixes
branch
from
c452dcb
to
ae21ece
Compare
Signed-off-by: Krishna Kondaka <[email protected]>
Signed-off-by: Krishna Kondaka <[email protected]>
…n information Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
force-pushed
the
ossink-log-fixes
branch
from
ae21ece
to
f53475b
Compare
Signed-off-by: Krishna Kondaka <[email protected]>
graytaylor0
previously approved these changes
Aug 22, 2024
| @@ -209,7 +209,7 @@ public void execute(final AccumulatingBulkRequest bulkRequest) throws Interrupte | |||
| request = operationResponse.getBulkRequest(); | |||
| exceptionMessage = operationResponse.getExceptionMessage(); | |||
| if (delayMillis < 0) { | |||
| RuntimeException e = new RuntimeException(String.format("Index : %s, Number of retries reached the limit of max retries (configured value %d. Last exception message: %s)", maxRetries, exceptionMessage)); | |||
There was a problem hiding this comment.
Why get rid of the index name here?
There was a problem hiding this comment.
@graytaylor0 I did not get rid of it. It is not available. I have mistakenly put it there in the previous revision.
There was a problem hiding this comment.
Index is available at each operation level. Not at bulk operation level.
graytaylor0
dismissed
their stale review
Build is failing due to failing tests in BulkRetryStrategy
Signed-off-by: Krishna Kondaka <[email protected]>
|
@KarstenSchnitter most of the changes are about adding index name. There is one place where exception message is printed. But this is no different from what we already do. |
graytaylor0
approved these changes
Sep 24, 2024
dlvenable
approved these changes
Sep 27, 2024
KarstenSchnitter
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OpenSearchSink -
Enhance logs to include index name where applicable
and add last exception information when giving up after retrying
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.