Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update sst version #313

Merged
merged 3 commits into from
Nov 7, 2023
Merged

chore: update sst version #313

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0646e4
chore: update sst version
khuezy Nov 7, 2023
3dd3966
add experimental.streaming = true
khuezy Nov 7, 2023
a505b2f
delete temporary NextjsSite wrapper
khuezy Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions examples/sst/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,11 @@
"version": "0.0.0",
"type": "module",
"private": true,
"scripts": {
},
"dependencies": {

},
"scripts": {},
"dependencies": {},
"devDependencies": {
"aws-cdk-lib": "2.91.0",
"aws-cdk-lib": "2.101.1",
"constructs": "10.2.69",
"sst": "2.24.24"
"sst": "2.35.1"
}
}
3 changes: 3 additions & 0 deletions examples/sst/stacks/AppRouter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ export function AppRouter({ stack }) {
bind: [],
environment: {},
timeout: "20 seconds",
experimental: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use the default NextJsSite here, no need to override anything anymore

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yea good call, updating...

streaming: true,
},
});

stack.addOutputs({
Expand Down
7 changes: 6 additions & 1 deletion packages/open-next/src/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,7 +964,12 @@ function getOpenNextVersion() {
}

function getNextVersion(nextPackageJsonPath: string) {
const version = require(nextPackageJsonPath).dependencies.next;
const version = require(nextPackageJsonPath)?.dependencies?.next;
// require('next/package.json').version

if (!version) {
throw new Error("Failed to find Next version");
}

// Drop the -canary.n suffix
return version.split("-")[0];
Expand Down
Loading
Loading