Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update sst version #313

Merged
merged 3 commits into from
Nov 7, 2023
Merged

chore: update sst version #313

merged 3 commits into from
Nov 7, 2023

Conversation

khuezy
Copy link
Collaborator

@khuezy khuezy commented Nov 7, 2023

No description provided.

@vercel Vercel
Copy link

vercel bot commented Nov 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-next ❌ Failed (Inspect) Nov 7, 2023 7:02pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: a505b2f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

conico974
conico974 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my comment, it looks good to me

examples/sst/stacks/AppRouter.ts
@@ -7,6 +7,9 @@ export function AppRouter({ stack }) {
bind: [],
environment: {},
timeout: "20 seconds",
experimental: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use the default NextJsSite here, no need to override anything anymore

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yea good call, updating...

@khuezy khuezy merged commit bf6b32d into opennextjs:main Nov 7, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conico974 conico974 conico974 approved these changes

@fwang fwang Awaiting requested review from fwang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khuezy @conico974