panel:Add an extensionSlot for lab tab panels #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirupius
requested changes
Jan 9, 2024
| @@ -71,6 +95,11 @@ const LaboratoryQueueTabs: React.FC = () => { | |||
| <CompletedList fulfillerStatus={"COMPLETED"} /> | |||
| </div> | |||
| </TabPanel> | |||
| <ExtensionSlot name={labPanelSlot}> | |||
There was a problem hiding this comment.
Am also hoping adding the check won't render this in the view unless there's an existing extension selected
There was a problem hiding this comment.
thanks Pius ....
by default its not rendering this in the view unless the corresponding extension has been been selected,
pirupius
reviewed
Jan 10, 2024
| })} | ||
| </Tab> | ||
| ))} | ||
| {tabExtensions |
There was a problem hiding this comment.
Please add the check here as well. Refer to previous comment
There was a problem hiding this comment.
hello @pirupius i added a check that makes sure that the title and name values of the extension.meta object are truthy before rendering the Tab which is automatically mapped to the corresponding TabPanel .
Kindly see the updated screenshot
3 tasks
pirupius
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Screenshots
Related Issue
Other