Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

03-2725:Remove other tabs from the labs app #31

Closed
wants to merge 3 commits into from

Conversation

gitcliff
Copy link
Contributor

@gitcliff gitcliff commented Jan 10, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

We would like to only retain the Tests ordered tab visible in the app UI .
Other tabs can be added via extensions according to implementation custom needs

Screenshots

Screenshot 2024-01-10 at 12 32 17 PM

Related Issue

https://openmrs.atlassian.net/browse/O3-2725

Other

Copy link
Member

@sherrif10 sherrif10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM . Thanks @gitcliff. To be specific you are keeping everything constant, isnt it ?

@gitcliff
Copy link
Contributor Author

LGTM . Thanks @gitcliff. To be specific you are keeping everything constant, isnt it ?

yes for now in regards to the spared tab

@ojwanganto
Copy link
Contributor

Why are we removing the other tabs?

@gitcliff
Copy link
Contributor Author

Why are we removing the other tabs?

Hello @ojwanganto according to yesterday's call Casey proposed that we only keep this tab visible .other tabs will be kept by implementers that need them ie UgandaEMR and more ones can still be added via extensions when this issue is merged .
All this is brought about by the desire to incorporate two workflows with the lab app ie the min lightweight LIS workflow which necessitates these tabs. The other mainstream external LIS system approach is. where we just have one tab ie Tests Ordered tab and let the LIS work be handle by the external LIS systems ie OpenELIS , Senite .

So am going to make these other tabs configurable via extensions

@gitcliff gitcliff marked this pull request as draft January 10, 2024 18:57
@ojwanganto
Copy link
Contributor

Makes sense to me. Thanks

@ojwanganto
Copy link
Contributor

Could we then fix whatever is failing and have this merged in? I think it is ready to go. Thanks

@@ -0,0 +1,18 @@
import React from "react";
import CompletedList from "../../completed-list/completed-list.component";
import styles from "./lab-tabs.scss";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI build is failing because the stylesheet is missing from your diff. Could you please add it, @gitcliff?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @denniskigen @ojwanganto ,,,,going to close this one as the detailed work on this has been updated in this PR https://github.com/openmrs/openmrs-esm-laboratory/pull/28

@gitcliff gitcliff closed this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants