-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
03-2725:Remove other tabs from the labs app #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM . Thanks @gitcliff. To be specific you are keeping everything constant, isnt it ?
yes for now in regards to the spared tab |
Why are we removing the other tabs? |
Hello @ojwanganto according to yesterday's call Casey proposed that we only keep this tab visible .other tabs will be kept by implementers that need them ie UgandaEMR and more ones can still be added via extensions when this issue is merged . So am going to make these other tabs configurable via extensions |
Makes sense to me. Thanks |
Could we then fix whatever is failing and have this merged in? I think it is ready to go. Thanks |
@@ -0,0 +1,18 @@ | |||
import React from "react"; | |||
import CompletedList from "../../completed-list/completed-list.component"; | |||
import styles from "./lab-tabs.scss"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI build is failing because the stylesheet is missing from your diff. Could you please add it, @gitcliff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @denniskigen @ojwanganto ,,,,going to close this one as the detailed work on this has been updated in this PR https://github.com/openmrs/openmrs-esm-laboratory/pull/28
Requirements
Summary
We would like to only retain the Tests ordered tab visible in the app UI .
Other tabs can be added via extensions according to implementation custom needs
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-2725
Other