Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Incorrect display mode for grouped items in side navigation #171

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

CynthiaKamau
Copy link
Contributor

@CynthiaKamau CynthiaKamau commented Jan 9, 2024

Requirements

Summary

  • Fixed incorrect display mode for grouped items in side navigation, flex mode hides items on the side
    @vasharma05 @denniskigen please confirm that there is no use case for this

Screenshots

Screenshot 2024-01-09 at 14 44 23

None.

Related Issue

None.

Other

None.

Copy link
Contributor

github-actions bot commented Jan 9, 2024

Size Change: -18 B (0%)

Total Size: 217 kB

ℹ️ View Unchanged
Filename Size Change
packages/esm-home-app/dist/130.js 173 kB 0 B
packages/esm-home-app/dist/319.js 131 B 0 B
packages/esm-home-app/dist/460.js 172 B 0 B
packages/esm-home-app/dist/574.js 131 B 0 B
packages/esm-home-app/dist/62.js 22.1 kB 0 B
packages/esm-home-app/dist/656.js 3.88 kB -9 B (0%)
packages/esm-home-app/dist/757.js 131 B 0 B
packages/esm-home-app/dist/784.js 2.63 kB 0 B
packages/esm-home-app/dist/788.js 131 B 0 B
packages/esm-home-app/dist/807.js 143 B 0 B
packages/esm-home-app/dist/833.js 144 B 0 B
packages/esm-home-app/dist/913.js 5.71 kB 0 B
packages/esm-home-app/dist/main.js 6.14 kB -9 B (0%)
packages/esm-home-app/dist/openmrs-esm-home-app.js 3.14 kB 0 B

compressed-size-action

Copy link

@ebambo ebambo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CynthiaKamau

@pirupius pirupius merged commit 7eef26a into main Jan 10, 2024
5 checks passed
@pirupius pirupius deleted the home-styles branch January 10, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants