Incorrect Display Mode for Grouped Items in Side Navigation (Flex Instead of Block)"

[CynthiaKamau]

https://github.com/openmrs/openmrs-esm-home/blame/4e16be566592d55c0d58353367f72e7fceb305f6/packages/esm-home-app/src/dashboard/home-dashboard.scss#L13

@denniskigen @vasharma05 what was the reason for adding this line ? For people using grouped links, it results in displaying the child links side by side as opposed to in a block format

[denniskigen]

Hey, @CynthiaKamau. iirc, this change was made here with the intention that it would be removed once 5bf80e1 got merged. Is that right, @donaldkibet? In local testing, have you found that the left nav links get rendered correctly when these styles get removed? Just the regular links first, before we move on to the grouped links. That could be a good place to start.

[CynthiaKamau]

Hey, @CynthiaKamau. iirc, this change was made here with the intention that it would be removed once 5bf80e1 got merged. Is that right, @donaldkibet? In local testing, have you found that the left nav links get rendered correctly when these styles get removed? Just the regular links first, before we move on to the grouped links. That could be a good place to start.

Yes, the normal links get rendered as expected when i remove the code snippet

[denniskigen]

Ok. Please go ahead and file a PR.

[CynthiaKamau]

Ok. Please go ahead and file a PR.

Already did : #171