Allowing CylindricalMesh and SphericalMesh to be fully made via constructor+ type hints #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eepeterson
reviewed
Jul 22, 2023
eepeterson
reviewed
Jul 22, 2023
shimwell
commented
Jul 23, 2023
shimwell
commented
Jul 23, 2023
shimwell
commented
Jul 23, 2023
paulromano
requested changes
Jul 28, 2023
Co-authored-by: Paul Romano <[email protected]>
paulromano
requested changes
Jul 28, 2023
shimwell
commented
Jul 29, 2023
paulromano
requested changes
Jul 29, 2023
paulromano
requested changes
Jul 30, 2023
shimwell
commented
Jul 30, 2023
shimwell
commented
Jul 30, 2023
shimwell
commented
Jul 30, 2023
Co-authored-by: Paul Romano <[email protected]>
Co-authored-by: Paul Romano <[email protected]>
|
I did have to tinker with a few extra test files that were calling openmc.CylindricalMesh() and openmc.SphericalMesh() without arguments (which is no longer not possible as we now have mandatory args) but looks like the CI is now passing 🎉 |
paulromano
approved these changes
Aug 5, 2023
There was a problem hiding this comment.
Sorry for the delay on this -- thanks for the updates @shimwell!
|
Many thanks Paul, sorry it was not the most tidy PR. |
2 tasks
stchaker
pushed a commit
to stchaker/openmc
that referenced
this pull request
Oct 25, 2023
…ructor+ type hints (openmc-dev#2619) Co-authored-by: Paul Romano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've been crawling through the code looking for classes that are not fully setable from their args and I found CylindricalMesh and SphericalMesh were just missing the origin arg.
So I've added that argument to their __ init __
While browsing the code I couldn't resist adding a few type hints
Fixes # (issue)
Checklist
- [ ] I have run clang-format on any C++ source files (if applicable)