Allowing WeightWindowGenerator to be fully made via constructor #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimwell
commented
Sep 6, 2023
paulromano
approved these changes
Sep 13, 2023
stchaker
pushed a commit
to stchaker/openmc
that referenced
this pull request
Oct 25, 2023
…mc-dev#2686) Co-authored-by: Paul Romano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following on the theme of making the python classes fully specified (e.g #2619 ) via the constructor this PR attempts to convert the WeightWindowGenerator class so that it can be made fully from the constructor.
only catch is that the
self._update_parametersmust be set before theself.methodas theself.methodsetter accesses this attribute.Checklist