Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for basic onespin support for cv32e40s #2410

Merged

Conversation

torjeikenes
Copy link

This PR adds support for loading the cv32e40s core into onespin.
While there's remaining work to properly integrate the assertions from cv32e40s_wrapper.sv, I'm still submitting the PR as discussed with @silabs-robin

Copy link
Contributor

@silabs-robin silabs-robin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. I think it is a very nice contribution.

I have some comments and questions.
(I will mark as resolved those that don't require any more action.)

@@ -0,0 +1,270 @@
# Copyright 2024 Torje Nygaard Eikenes
#
# SPDX-License-Identifier: Apache-2.0 WITH SHL-2.1
Copy link
Contributor

@silabs-robin silabs-robin Apr 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeOpenHWGroup , do the copyright and license look ok to you?
Correct version and format and everything?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SPDX header is all-good. It is fine with OpenHW that Torje claims the copyright for themselves, but it does depend on whether or not there is an employment agreement between Torje and SiLabs. Depending on the wording of that agreement, the copyright might be held by Silicon Labs, not Torje Nygaard Eikenes.

cv32e40s/fv/Makefile Show resolved Hide resolved
cv32e40s/tb/uvmt/uvmt_cv32e40s_tb.sv Show resolved Hide resolved
cv32e40s/fv/onespin.tcl Show resolved Hide resolved
cv32e40s/fv/onespin.tcl Show resolved Hide resolved
cv32e40s/fv/onespin.tcl Show resolved Hide resolved
@silabs-robin silabs-robin added cv32e40s formal Anything related to properties, asserts, covers and assumptions used in FV. labels Apr 16, 2024
Copy link
Contributor

@silabs-robin silabs-robin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to get access to run it myself, but haven't achieved that. So I will approve based only on reading the code.

All feedback comments have been resolved.
Almost only fv/ is affected.
Looks good. Approving.

@silabs-robin silabs-robin merged commit 2b3b3cb into openhwgroup:cv32e40s/release Apr 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cv32e40s formal Anything related to properties, asserts, covers and assumptions used in FV.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants