Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BD-46] feat: typescript coverage #2443

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
+948 −0
Draft

[BD-46] feat: typescript coverage #2443

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b04dd84
feat: add typecov coverage
Jul 18, 2023
0f2af8a
feat: add typecov coverage
Jul 19, 2023
b7f800f
refactor: added typecov
PKulkoRaccoonGang Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ jobs:
run: npm run build-docs
- name: Coverage
uses: codecov/codecov-action@v3
- name: Type check
uses: codechecks/typecov
- name: Extract branch name
shell: bash
run: echo "##[set-output name=branch;]$(echo ${GITHUB_REF#refs/heads/})"
Expand Down
4 changes: 4 additions & 0 deletions codechecks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
checks:
- name: typecov
options:
- atLeast: 99
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] Given TS is still relatively new for Open edX / Paragon, I'd suggest not enforcing any specific coverage targets quite yet. That is, at least to start, I'd like this be more of an inform on PRs rather than something that will block PRs from merging