-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] feat: typescript coverage #2443
base: master
Are you sure you want to change the base?
[BD-46] feat: typescript coverage #2443
Conversation
Thanks for the pull request, @monteri! This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2443 +/- ##
=======================================
Coverage 91.38% 91.38%
=======================================
Files 234 234
Lines 4157 4157
Branches 1001 1001
=======================================
Hits 3799 3799
Misses 351 351
Partials 7 7 ☔ View full report in Codecov by Sentry. |
b72c3f3
to
45e9bc3
Compare
45e9bc3
to
b04dd84
Compare
checks: | ||
- name: typecov | ||
options: | ||
- atLeast: 99 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[suggestion] Given TS is still relatively new for Open edX / Paragon, I'd suggest not enforcing any specific coverage targets quite yet. That is, at least to start, I'd like this be more of an inform on PRs rather than something that will block PRs from merging
Description
Include a description of your changes here, along with a link to any relevant Jira tickets and/or Github issues.
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist