Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] feat: typescript coverage #2443

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

monteri
Copy link
Contributor

@monteri monteri commented Jul 14, 2023

Description

Include a description of your changes here, along with a link to any relevant Jira tickets and/or Github issues.

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Jul 14, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 14, 2023

Thanks for the pull request, @monteri!

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@netlify
Copy link

netlify bot commented Jul 14, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b7f800f
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/64cbce4d0e13bb000855000b
😎 Deploy Preview https://deploy-preview-2443--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@monteri monteri marked this pull request as draft July 14, 2023 12:15
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0fc542f) 91.38% compared to head (cd06f1e) 91.38%.
Report is 34 commits behind head on master.

❗ Current head cd06f1e differs from pull request most recent head b7f800f. Consider uploading reports for the commit b7f800f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2443   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files         234      234           
  Lines        4157     4157           
  Branches     1001     1001           
=======================================
  Hits         3799     3799           
  Misses        351      351           
  Partials        7        7           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@monteri monteri force-pushed the zadorozhnii/typescript-coverage-ci branch 3 times, most recently from b72c3f3 to 45e9bc3 Compare July 18, 2023 15:10
@monteri monteri force-pushed the zadorozhnii/typescript-coverage-ci branch from 45e9bc3 to b04dd84 Compare July 19, 2023 08:06
checks:
- name: typecov
options:
- atLeast: 99
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] Given TS is still relatively new for Open edX / Paragon, I'd suggest not enforcing any specific coverage targets quite yet. That is, at least to start, I'd like this be more of an inform on PRs rather than something that will block PRs from merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants