-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove retry button in LTI Proctorio exams #155
Conversation
use_legacy_attempt_api: true, | ||
attempt_status: ExamStatus.SUBMITTED, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now if a Proctored exam with an LTI provider is submitted no longer shows the "Retry my exam" button. That's the reason for this update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: we should remove LTI from this since LTI implies the new (not legacy) exam system
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
+ Coverage 94.16% 94.29% +0.12%
==========================================
Files 68 68
Lines 1079 1086 +7
Branches 295 300 +5
==========================================
+ Hits 1016 1024 +8
+ Misses 58 57 -1
Partials 5 5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
// It does not show the reload button if the exam is submitted and not legacy | ||
const showRetryButton = !( | ||
exam.attempt?.attempt_status === ExamStatus.SUBMITTED | ||
&& !exam.attempt?.use_legacy_attempt_api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this boolean value come from backend API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so. I was using this usage as a reference:
https://github.com/openedx/frontend-lib-special-exams/blob/rijuma-remove-retry-on-lti-proctorio-tests/src/instructions/proctored_exam/SubmitProctoredExamInstructions.jsx#L16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It's using setExamState() which uses fetchExamAttemptsData() to call an API.
use_legacy_attempt_api: true, | ||
attempt_status: ExamStatus.SUBMITTED, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: we should remove LTI from this since LTI implies the new (not legacy) exam system
Description
Ticket: COSMO-512 🔒
After submitting a Practice Proctoring exam there's a "Retry my exam" that if clicked throws an Axios 400 error:
A Practice Proctoring exam that has an LTI provider cannot be retried. This update removes the button on such cases.