Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fixed displaying banner and certificates on mobile view (palm.master) #861

Conversation

vladislavkeblysh
Copy link
Contributor

@vladislavkeblysh vladislavkeblysh commented Oct 10, 2023

  • Fixed displaying banner on mobile view
  • Fixed displaying list of certificates on mobile view

Screenshot 2023-10-10 at 10 38 05
Screenshot 2023-10-10 at 10 36 06

@openedx-webhooks
Copy link

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 10, 2023
@vladislavkeblysh vladislavkeblysh changed the title feat: Fixed displaying banner and certificates on mobile view feat: Fixed displaying banner and certificates on mobile view (Palm.master) Oct 10, 2023
@vladislavkeblysh vladislavkeblysh changed the title feat: Fixed displaying banner and certificates on mobile view (Palm.master) feat: Fixed displaying banner and certificates on mobile view (palm.master) Oct 10, 2023
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 10, 2023
@e0d
Copy link

e0d commented Oct 10, 2023

@vladislavkeblysh seeing some linting failures.

@e0d e0d added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Oct 10, 2023
@vladislavkeblysh
Copy link
Contributor Author

@e0d Fixed

@hurtstotouchfire hurtstotouchfire added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Oct 12, 2023
@justinhynes
Copy link
Contributor

I'll be reviewing this today.

@justinhynes justinhynes merged commit 06e827b into openedx:open-release/palm.master Oct 16, 2023
1 check passed
@openedx-webhooks
Copy link

@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs maintainer attention Issue or PR specifically needs the attention of the maintainer. open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants