Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fixed displaying banner and certificates on mobile view #860

Conversation

vladislavkeblysh
Copy link
Contributor

@vladislavkeblysh vladislavkeblysh commented Oct 10, 2023

  • Fixed displaying banner on mobile view
  • Fixed displaying list of certificates on mobile view

Screenshot 2023-10-10 at 10 36 06
Screenshot 2023-10-10 at 10 38 05

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 10, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 10, 2023

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 10, 2023
@e0d
Copy link

e0d commented Oct 10, 2023

@vladislavkeblysh seeing some linting failures.

@e0d e0d added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Oct 10, 2023
@vladislavkeblysh
Copy link
Contributor Author

vladislavkeblysh commented Oct 11, 2023

@e0d Fixed

@openedx-webhooks
Copy link

@vladislavkeblysh Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 17, 2023
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/certificates-banner-styles branch from f64c8bd to 7a8eea6 Compare November 25, 2023 13:54
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9948527) 66.82% compared to head (7a8eea6) 66.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #860   +/-   ##
=======================================
  Coverage   66.82%   66.82%           
=======================================
  Files          52       52           
  Lines         850      850           
  Branches      176      176           
=======================================
  Hits          568      568           
  Misses        272      272           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vladislavkeblysh
Copy link
Contributor Author

This MR in palm.master already was merged. #861
Please, check this MR on master

@justinhynes justinhynes merged commit e59ab99 into openedx:master Jan 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants