Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Fixed displaying banner and certificates on mobile view #860

Merged
merged 2 commits into from
Jan 8, 2024
Merged

feat: Fixed displaying banner and certificates on mobile view #860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c9d935
feat: fixed displaing banner and certificates on mobile view
vladislavkeblysh Oct 9, 2023
7a8eea6
feat: update snapshot
vladislavkeblysh Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/profile/Banner.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';

const Banner = () => <div className="profile-page-bg-banner bg-primary d-none d-md-block p-relative" />;
const Banner = () => <div className="profile-page-bg-banner bg-primary d-md-block p-relative" />;

export default Banner;
32 changes: 16 additions & 16 deletions src/profile/__snapshots__/ProfilePage.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ exports[`<ProfilePage /> Renders correctly in various states app loading 1`] = `
className="profile-page"
>
<div
className="profile-page-bg-banner bg-primary d-none d-md-block p-relative"
className="profile-page-bg-banner bg-primary d-md-block p-relative"
/>
<div>
<div
Expand Down Expand Up @@ -36,7 +36,7 @@ exports[`<ProfilePage /> Renders correctly in various states test country edit w
className="profile-page"
>
<div
className="profile-page-bg-banner bg-primary d-none d-md-block p-relative"
className="profile-page-bg-banner bg-primary d-md-block p-relative"
/>
<div
className="container-fluid"
Expand Down Expand Up @@ -2307,7 +2307,7 @@ exports[`<ProfilePage /> Renders correctly in various states test country edit w
className="row align-items-stretch"
>
<div
className="col col-sm-6 d-flex align-items-stretch"
className="col-12 col-sm-6 d-flex align-items-stretch"
>
<div
className="card mb-4 certificate flex-grow-1"
Expand Down Expand Up @@ -2419,7 +2419,7 @@ exports[`<ProfilePage /> Renders correctly in various states test education edit
className="profile-page"
>
<div
className="profile-page-bg-banner bg-primary d-none d-md-block p-relative"
className="profile-page-bg-banner bg-primary d-md-block p-relative"
/>
<div
className="container-fluid"
Expand Down Expand Up @@ -3484,7 +3484,7 @@ exports[`<ProfilePage /> Renders correctly in various states test education edit
className="row align-items-stretch"
>
<div
className="col col-sm-6 d-flex align-items-stretch"
className="col-12 col-sm-6 d-flex align-items-stretch"
>
<div
className="card mb-4 certificate flex-grow-1"
Expand Down Expand Up @@ -3596,7 +3596,7 @@ exports[`<ProfilePage /> Renders correctly in various states test preferreded la
className="profile-page"
>
<div
className="profile-page-bg-banner bg-primary d-none d-md-block p-relative"
className="profile-page-bg-banner bg-primary d-md-block p-relative"
/>
<div
className="container-fluid"
Expand Down Expand Up @@ -5536,7 +5536,7 @@ exports[`<ProfilePage /> Renders correctly in various states test preferreded la
className="row align-items-stretch"
>
<div
className="col col-sm-6 d-flex align-items-stretch"
className="col-12 col-sm-6 d-flex align-items-stretch"
>
<div
className="card mb-4 certificate flex-grow-1"
Expand Down Expand Up @@ -5648,7 +5648,7 @@ exports[`<ProfilePage /> Renders correctly in various states viewing other profi
className="profile-page"
>
<div
className="profile-page-bg-banner bg-primary d-none d-md-block p-relative"
className="profile-page-bg-banner bg-primary d-md-block p-relative"
/>
<div
className="container-fluid"
Expand Down Expand Up @@ -6133,7 +6133,7 @@ exports[`<ProfilePage /> Renders correctly in various states viewing own profile
className="profile-page"
>
<div
className="profile-page-bg-banner bg-primary d-none d-md-block p-relative"
className="profile-page-bg-banner bg-primary d-md-block p-relative"
/>
<div
className="container-fluid"
Expand Down Expand Up @@ -7071,7 +7071,7 @@ exports[`<ProfilePage /> Renders correctly in various states viewing own profile
className="row align-items-stretch"
>
<div
className="col col-sm-6 d-flex align-items-stretch"
className="col-12 col-sm-6 d-flex align-items-stretch"
>
<div
className="card mb-4 certificate flex-grow-1"
Expand Down Expand Up @@ -7183,7 +7183,7 @@ exports[`<ProfilePage /> Renders correctly in various states while saving an edi
className="profile-page"
>
<div
className="profile-page-bg-banner bg-primary d-none d-md-block p-relative"
className="profile-page-bg-banner bg-primary d-md-block p-relative"
/>
<div
className="container-fluid"
Expand Down Expand Up @@ -8188,7 +8188,7 @@ exports[`<ProfilePage /> Renders correctly in various states while saving an edi
className="row align-items-stretch"
>
<div
className="col col-sm-6 d-flex align-items-stretch"
className="col-12 col-sm-6 d-flex align-items-stretch"
>
<div
className="card mb-4 certificate flex-grow-1"
Expand Down Expand Up @@ -8300,7 +8300,7 @@ exports[`<ProfilePage /> Renders correctly in various states while saving an edi
className="profile-page"
>
<div
className="profile-page-bg-banner bg-primary d-none d-md-block p-relative"
className="profile-page-bg-banner bg-primary d-md-block p-relative"
/>
<div
className="container-fluid"
Expand Down Expand Up @@ -9313,7 +9313,7 @@ exports[`<ProfilePage /> Renders correctly in various states while saving an edi
className="row align-items-stretch"
>
<div
className="col col-sm-6 d-flex align-items-stretch"
className="col-12 col-sm-6 d-flex align-items-stretch"
>
<div
className="card mb-4 certificate flex-grow-1"
Expand Down Expand Up @@ -9425,7 +9425,7 @@ exports[`<ProfilePage /> Renders correctly in various states without credentials
className="profile-page"
>
<div
className="profile-page-bg-banner bg-primary d-none d-md-block p-relative"
className="profile-page-bg-banner bg-primary d-md-block p-relative"
/>
<div
className="container-fluid"
Expand Down Expand Up @@ -10273,7 +10273,7 @@ exports[`<ProfilePage /> Renders correctly in various states without credentials
className="row align-items-stretch"
>
<div
className="col col-sm-6 d-flex align-items-stretch"
className="col-12 col-sm-6 d-flex align-items-stretch"
>
<div
className="card mb-4 certificate flex-grow-1"
Expand Down
2 changes: 1 addition & 1 deletion src/profile/forms/Certificates.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class Certificates extends React.Component {
})();

return (
<div key={`${modifiedDate}-${courseId}`} className="col col-sm-6 d-flex align-items-stretch">
<div key={`${modifiedDate}-${courseId}`} className="col-12 col-sm-6 d-flex align-items-stretch">
<div className="card mb-4 certificate flex-grow-1">
<div
className="certificate-type-illustration"
Expand Down