feat: Added dev and prod targets. #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zubairshakoorarbisoft
requested review from
awais786,
UsamaSadiq and
iamsobanjaved
timmc-edx
reviewed
Oct 10, 2023
timmc-edx
reviewed
Oct 10, 2023
timmc-edx
approved these changes
Oct 11, 2023
iamsobanjaved
approved these changes
Oct 11, 2023
| # Devstack related step for backwards compatibility | ||
| RUN touch {{cookiecutter.project_name}}/{{cookiecutter.project_name}}_env | ||
|
|
||
| CMD while true; do python ./manage.py runserver 0.0.0.0:{{cookiecutter.port}}; sleep 2; done |
There was a problem hiding this comment.
Nit: add blank line at the end of file
| docker buildx build -t openedx/{{cookiecutter.repo_name}}:latest -t openedx/{{cookiecutter.repo_name}}:${GITHUB_SHA} --platform linux/amd64,linux/arm64 --target production --push . | ||
|
|
||
| docker_tag_build_push_dev: docker_auth | ||
| docker buildx build -t openedx/{{cookiecutter.repo_name}}-dev:latest -t openedx/{{cookiecutter.repo_name}}-dev:${GITHUB_SHA} --platform linux/amd64,linux/arm64 --target development --push . |
There was a problem hiding this comment.
You have defined the target in Dockerfile as dev so this should be dev as well.
There was a problem hiding this comment.
Ooh, that's a good catch! Same for prod/production.
There was a problem hiding this comment.
Thanks @iamsobanjaved. It's fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #292
Merge checklist:
Check off if complete or not applicable: