Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dockerfile for Django IDA cookiecutter #292

Closed
iamsobanjaved opened this issue Feb 10, 2023 · 2 comments
Closed

Improve Dockerfile for Django IDA cookiecutter #292

iamsobanjaved opened this issue Feb 10, 2023 · 2 comments
Assignees

Comments

@iamsobanjaved
Copy link
Contributor

iamsobanjaved commented Feb 10, 2023

Parent Issue: openedx-unsupported/devstack#943

As we have been improving the native Dockerfile in all of our existing IDAs which are being used in devstack. So we should update the Dockerfile of Django IDA cookie-cutter so that all newly created IDAs should have this functionality out of the box.

The Dockerfile of the IDA should have the following things:

  • Ensure that the repo's Dockerfile can create a base image that is appropriate for small production installations
  • Ensure that the repo's Dockerfile also defines an additional image derived from the base which adds dependencies and configuration changes needed for development environments
  • Automate uploads of both images when code changes are merged

Dockerfile: https://github.com/openedx/edx-cookiecutters/blob/master/cookiecutter-django-ida/%7B%7Bcookiecutter.repo_name%7D%7D/Dockerfile

@jmbowman
Copy link
Contributor

I ran into this one during Innovation Week. https://github.com/edx/flashcards/blob/main/Dockerfile was my quick attempt at this for a single new service (that needed Python 3.9 for a specific dependency), might be useful for reference.

@iamsobanjaved
Copy link
Contributor Author

Implemented in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants