Add build agent for Node.js 18 (master) #795
Conversation
|
Hm, builds are failing. Doesn't find all of the dependencies yet. Maybe because Node.js 18 was released only a week ago. I'll try again later and keep you posted. |
| FROM opendevstackorg/ods-jenkins-agent-base-ubi8:latest | ||
|
|
||
| # Labels consumed by Red Hat build service | ||
| LABEL com.redhat.component="jenkins-agent-nodejs-18-rhel7-container" \ |
There was a problem hiding this comment.
isn't it ubi8 instead of rhel7 ?
There was a problem hiding this comment.
Now as I look at this... the labels section definitely needs improvement. Regarding this topic there seems to be #506 for dealing with this on all agents. I would not fix it with this PR.
There was a problem hiding this comment.
I'd prefer to fix it now.
| - name: ODS_GIT_REF | ||
| required: true | ||
| - name: JENKINS_AGENT_DOCKERFILE_PATH | ||
| value: Dockerfile.centos7 |
There was a problem hiding this comment.
should we default to ubi8 ?
There was a problem hiding this comment.
I'm wondering why we have those two flavors of the Dockerfile in the first place.
@michaelsauter @braisvq1996 Do we still need both?
There was a problem hiding this comment.
We have both because centos7 was used for Openshift 3 installation and ubi8 for Openshift 4 -> Check config
Better maintain both until we decide to drop Openshift 3 completely.
|
Hi @cschweikert @tbugfinder -> nodesource |
|
@braisvq1996 good point. Does anything speak against moving on to Centos/RHEL 8? Like already mentioned in one of the discussions above I have no clue about the implications of this switch (e.g. just for the nodejs18 thingy). If it is fine, I can also try that out for now. |
|
Switching to Centos8 and/or Rhel8 is a big change. |
|
@braisvq1996 I think this just confirms that you'll need to investigate an alternative to the current ODS Box. Maintaining CentOS/RHEL7 base images will be a hassle more and more, plus the box is OpenShift 3.11 only so won't give you reliable results. The box should not block the uptake of Node 18 I believe. |
|
@michaelsauter you have your reason, the box is using OKD3, and this does not "help" for Openshift 4 tests.... |
|
As per my understanding nodejs project will not build CentOS7 binaries. So for CentOS7 we could compile proper GLIBC version 2.27 within the Image and see if that would work with the RHEL8 binary. In regards to the ubi8 image, do you want to wait for RHEL providing nodejs18 repo (sounds like Sept/Oct timeframe) or use the installer of the CentOS7 Dockerfile which would already be available. |
|
@braisvq1996 @cschweikert IMHO, CentOS7 support has to dropped here to move forward. |
|
@tbugfinder @cschweikert centos agents have been removed so if the conficts get resolved we could merge this into master |
|
I have already removed centos from this pr so if there is anything left to update as it has been quite some time since its creation we can do it and merge it |
|
@braisvq1996 thanks finishing this one ❤️ |
Fixes #794
Tasks:
docs/modules/...directory