Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node 18 image #585

Closed
michaelsauter opened this issue Jul 12, 2022 · 5 comments · Fixed by #649
Closed

Add Node 18 image #585

michaelsauter opened this issue Jul 12, 2022 · 5 comments · Fixed by #649
Assignees
@henninggross
Labels
enhancement New feature or request
Milestone
0.9.0

Comments

@michaelsauter
Copy link
Member

Related to opendevstack/ods-quickstarters#795.

We can and should still support the Node 16 image, we'd only make 18 the new default in the task param.

@cschweikert something you could / want to contribute?
@michaelsauter michaelsauter added the enhancement New feature or request label Jul 12, 2022
@cschweikert
Copy link
Member

There is no nodejs version 18 available yet for ubi8 (registry.access.redhat.com/ubi8/nodejs-18 is missing). I guess we would need to wait for it. I'll check from time to time and when it is there I'd continue here.

@michaelsauter
Copy link
Member Author

Oh I see. Yes then we need to wait. Same story for Go 1.18 ;) Thanks for checking regularly!

@tbugfinder
Copy link

tbugfinder commented Jul 25, 2022 •
edited
Loading

How do you decide if an installation package has to come from RedHat or the nodejs/go packages are sufficient?

@michaelsauter
Copy link
Member Author

At the moment, all base images in this repo are UBI images provided by RedHat. This makes maintenance simple and consistent. Typically I think waiting a few more weeks/months doesn't hurt anyone really. Also keep in mind that ODS pipeline is just Tekton, so you can anyway use any image you want by supplying your own task ... :)

@michaelsauter
Copy link
Member Author

@cschweikert it is available now: https://catalog.redhat.com/software/containers/ubi8/nodejs-18/6278e5c078709f5277f26998 🎉

@michaelsauter michaelsauter added this to the 0.9.0 milestone Jan 6, 2023
@henninggross henninggross self-assigned this Jan 6, 2023
@henninggross henninggross mentioned this issue Jan 17, 2023
Merged
4 tasks
@henninggross henninggross linked a pull request Jan 17, 2023 that will close this issue
add Node 18 image #649
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henninggross henninggross

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

add Node 18 image opendevstack/ods-pipeline
4 participants
@michaelsauter @tbugfinder @cschweikert @henninggross