-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update runtime's python packages #706
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -1,24 +1,24 @@ | |||
# Copied from: https://github.com/elyra-ai/elyra/blob/main/etc/generic/requirements-elyra.txt | |||
|
|||
# This is a comprehensive list of python dependencies that Elyra requires to execute Jupyter notebooks. | |||
ipykernel==6.13.0 | |||
ipython==8.10.0 | |||
ipykernel==6.29.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harshad16 I've manually updated this file to the latest versions, and I've applied the same versions to the Pipfiles example as well.
The packages on the requirments.txt on elyra repo looks old: https://github.com/elyra-ai/elyra/blob/main/etc/generic/requirements-elyra.txt
Since I wasn't certain which versions to use, I opted to go with the latest updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I would remove any changes to these requirements-elyra.txt
files from this PR. Or delete them completely to comply with: https://issues.redhat.com/browse/RHOAIENG-11068.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the changes look good.
as we are not using the requirements-elyra.txt, we would anyway use the https://issues.redhat.com/browse/RHOAIENG-11068, to de-clutter this.
@atheo89: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything looks good
just one note
memray = "~=1.10.0" # any version above this would cause issue with rich package | ||
boto3 = "~=1.35.14" | ||
kafka-python-ng = "~=2.2.2" | ||
kfp = "~=2.9.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the kfp , package is not needed in the runtime
Related to: https://issues.redhat.com/browse/RHOAIENG-13121
Description
How Has This Been Tested?
Merge criteria: