Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin kfp to the latest 2.5.0 release. #705

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dibryant
Copy link
Contributor

Partially fixes: https://issues.redhat.com/browse/RHOAIENG-11623

Description

Pin kfp to the latest 2.5.0 release.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign paulovmr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dibryant
Copy link
Contributor Author

Working on piplock files system giving me problems

Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

@dibryant: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rocm-notebooks-e2e-tests e511fc3 link true /test rocm-notebooks-e2e-tests
ci/prow/notebooks-ubi9-e2e-tests e511fc3 link true /test notebooks-ubi9-e2e-tests
ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror e511fc3 link true /test notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror
ci/prow/images e511fc3 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@atheo89
Copy link
Member

atheo89 commented Sep 20, 2024

Adding the first part created by @jstourac as ref: #702.
But still not sure if we should or not add this on tensorflows based on #702 (comment)

@jstourac
Copy link
Member

jstourac commented Sep 20, 2024

Thank you for this, @dibryant . Two points:

  1. As Adriana mentioned, I'm not sure whether pinning to 2.5 makes much sense. But maybe we can do it and put some comment with link and explanation why we pin to 2.5 version only on that line.
  2. Is there a reason to do this partially now? I think it makes sense to do it as a complete update to satisfy the https://issues.redhat.com/browse/RHOAIENG-11623 fully; unless I'm missing something.

Working on piplock files system giving me problems

Feel free to share. It works for me:

~/workspace/rhosai/odh/notebooks/jupyter/rocm/tensorflow/ubi9-python-3.11 on  e511fc3f! ⌚ 12:44:38
$ pipenv lock   
Locking [packages] dependencies...
Building requirements...
Resolving dependencies...
✔ Success!
Locking [dev-packages] dependencies...
Updated Pipfile.lock (58ac513f79c0b63a581d46d2cd8fb401d6382d45c83920b461ff37d76175c438)!

$ pipenv --version
pipenv, version 2024.0.1

$ python --version
Python 3.12.6

$ pip --version                                  
pip 23.3.2 from /usr/lib/python3.12/site-packages/pip (python 3.12)

@jstourac
Copy link
Member

Note: runtime images will be probably resolved for the kfp pin via #706.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants