Switch base image to UBI for AMD rocm install #620
Conversation
|
Skipping CI for Draft Pull Request. |
jiridanek
added
the
trivy-scan
|
Looks like we need to update the prow configuration then too: |
|
Also Makefile should be updated (in this PR), to reference ubi9- and not c9s- dir. |
harshad16
changed the title
|
We're still running out of disk space on one of the images, as @caponetto observed yesterday. |
so openshift-ci needs to be updated |
|
@jstourac so, approving in GitHub UI gives BOTH LGTM and approved, now that we are approvers. Gotta be careful. |
At first, I thought that was happening only during Trivy scan because it has to copy stuff around. But then I saw that CI is running out of disk space even during the build step for |
|
Apparently, there are more people concerned about rocm+pytorch size (see ROCm/ROCm-docker#120) |
|
To fix the ci please check this PR: #627 explains the instructions on how you can update the notebook matrix |
- switch to rocm naming convention - adjust the makefile with ubi changes Signed-off-by: Harshad Reddy Nalla <[email protected]>
|
@harshad16: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm /override ci/prow/images |
|
@atheo89: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atheo89, jiridanek, jstourac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
let me try /override "build (rocm-jupyter-pytorch-ubi9-python-3.9) / build" |
|
@jiridanek: Overrode contexts on behalf of jiridanek: build (rocm-jupyter-pytorch-ubi9-python-3.9) / build, ci/prow/images, ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-9-pr-image-mirror, ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-9-pr-image-mirror, ci/prow/rocm-notebooks-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "build (rocm-jupyter-pytorch-ubi9-python-3.9) / build" |
|
@jiridanek: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit bc3b27e
into
opendatahub-io:main
This is a followup to * opendatahub-io#620 (review)
…#632) This is a followup to * #620 (review)
Description
Switch base image to UBI for AMD rocm install
Related-to: https://issues.redhat.com/browse/RHOAIENG-7501
How Has This Been Tested?
Merge criteria: