-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate rocm-pytorch and rocm-tensorflow runtime images #626
Conversation
|
e18b042
to
213e4e1
Compare
/retest-required |
Based on CI builds ROCm Runtime PyTorch build: |
This PR is ready for a final review |
Is the openshift-ci still supposed to be failing?
|
Not sure what is happening on CI... There is a follow up PR however that incorporates more things openshift/release#54579 |
/test runtime-rocm-tensorflow-ubi9-python-3-9-pr-image-mirror |
The images fail to get build due to the node was low on resource: ephemeral-storage. Threshold quantity: 32127475555, available: 31169256Ki.
|
/retest |
/override ci/prow/runtimes-ubi9-e2e-tests |
@atheo89: Overrode contexts on behalf of atheo89: ci/prow/runtimes-ubi8-e2e-tests, ci/prow/runtimes-ubi9-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/rocm-notebooks-e2e-tests |
@atheo89: Overrode contexts on behalf of atheo89: ci/prow/rocm-notebooks-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/rocm-notebooks-e2e-tests /test rocm-runtimes-ubi9-e2e-tests |
@atheo89: Overrode contexts on behalf of atheo89: ci/prow/rocm-notebooks-e2e-tests, ci/prow/runtimes-ubi8-e2e-tests, ci/prow/runtimes-ubi9-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test rocm-runtimes-ubi9-e2e-tests |
@atheo89: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks for the work 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related to: https://issues.redhat.com/browse/RHOAIENG-9680
Depends on: #620
Description
Include PyTorch AMD and Tensorflow AMD images in the pre-included runtime image lists.
We need to provide runtime images with AMD support so that they can be used in the Pipeline creation via Elyra component or directly.
NOTE: This PR has dependency of this one: #620 as for the runtime builds the base image is
amd-ubi9-python-3.9
Follow up items that will break up on different tracking tasks:
AMD
toROCM
as more proper nameMerge criteria: