Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add kubectl kustomize run to check our manifests definition #545

Merged
merged 1 commit into from
May 31, 2024

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented May 29, 2024

Added a simple check to CI to run kubectl kustomize so we are sure that our kustomization.yml files don't fail with an error. This should avoid issues like this in the future hopefully red-hat-data-services#253.

This is tested automatically by this PR.

This should be backported to our downstream repo.

https://issues.redhat.com/browse/RHOAIENG-7886

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented May 29, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

- name: Check kustomize manifest
id: kustomize-manifests
run: |
type kubectl || echo TODO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set -x, to avoid having to write these echos?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe in the future - I added also extra lines with ---- separators for better text separation visually

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

banners; meh

image

;P

@jiridanek
Copy link
Member

This job runs

---
name: Code static analysis
on: [pull_request] # yamllint disable-line rule:truthy

I think that it should be push and pull_request, so that it's possible to test it on personal fork, before creating a PR. Wdyt?

@openshift-ci openshift-ci bot added the lgtm label May 29, 2024
Copy link
Contributor

openshift-ci bot commented May 29, 2024

New changes are detected. LGTM label has been removed.

@jiridanek jiridanek added the lgtm label May 29, 2024
@jstourac
Copy link
Member Author

This job runs

---
name: Code static analysis
on: [pull_request] # yamllint disable-line rule:truthy

I think that it should be push and pull_request, so that it's possible to test it on personal fork, before creating a PR. Wdyt?

Probably we can, I'm not sure what else this change will cause. But I'm not gonna do it in this PR 🙂

@jstourac jstourac marked this pull request as ready for review May 29, 2024 16:06
@openshift-ci openshift-ci bot requested review from atheo89 and dibryant May 29, 2024 16:06
@jstourac jstourac requested review from harshad16 and removed request for dibryant May 29, 2024 16:07
@jiridanek
Copy link
Member

/retest

1 similar comment
@jiridanek
Copy link
Member

/retest

Copy link
Contributor

openshift-ci bot commented May 30, 2024

@jstourac: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 34bafd4 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jiridanek
Copy link
Member

This job runs

---
name: Code static analysis
on: [pull_request] # yamllint disable-line rule:truthy

I think that it should be push and pull_request, so that it's possible to test it on personal fork, before creating a PR. Wdyt?

Probably we can, I'm not sure what else this change will cause. But I'm not gonna do it in this PR 🙂

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

👍

@harshad16 harshad16 merged commit 876b724 into opendatahub-io:main May 31, 2024
1 of 3 checks passed
Copy link
Contributor

openshift-ci bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstourac jstourac deleted the addCiKustomize branch May 31, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants