-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] This fixes an inconsistency with the kustomize params #253
[fix] This fixes an inconsistency with the kustomize params #253
Conversation
Inconsistency for codeserver notebook parameters. There was upstream change recently that probably not got properly backported to downstream, see [1,2]. * [1] opendatahub-io#524 * [2] red-hat-data-services@ceb3dc8
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Great catch 💯
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-8121
Inconsistency for codeserver notebook parameters. There was upstream change recently that probably not got properly backported to downstream, see [1,2].
https://issues.redhat.com/browse/RHOAIENG-8121
https://issues.redhat.com/browse/RHOAIENG-7884
Tested locally with:
$ kubectl kustomize manifests/base
I'll extend our CI to run this command when anything in manifests is changed - update: opendatahub-io#545
The CI failures should be fixed by: