Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update references to logging exporter #1178

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −7
Open

fix: update references to logging exporter #1178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc34371
examples: update references to logging exporter
codeboten Sep 20, 2024
83747d7
update example to use v0.109.0 of the collector
codeboten Sep 20, 2024
157f565
Merge branch 'main' into codeboten/rm-logging-references
codeboten Sep 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ services:
image: memcached:alpine
command: memcached -m 64
ports:
- "11211:11211"
- "11211:11211"

zookeeper:
image: confluentinc/cp-zookeeper:latest
Expand Down Expand Up @@ -248,8 +248,8 @@ services:
- "16686:16686"

otelcol:
image: otel/opentelemetry-collector:0.54.0
command: [ "--config=/etc/otelcol-config.yml" ]
image: otel/opentelemetry-collector:0.109.0
command: ["--config=/etc/otelcol-config.yml"]
volumes:
- ./otelcol-config.yml:/etc/otelcol-config.yml
ports:
Expand Down
10 changes: 6 additions & 4 deletions otelcol-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,15 @@ receivers:
otlp:
protocols:
grpc:
endpoint: 0.0.0.0:4317
http:
endpoint: 0.0.0.0:4318
exporters:
jaeger:
endpoint: "jaeger:14250"
otlp:
endpoint: "jaeger:4317"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should 'jaeger' also be modified here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hm, disregard i suppose? Do we need to expose this port on the jaeger container tho? Sorry been a minute since I've peaked at this setup

tls:
insecure: true
logging:
debug:

processors:
batch:
Expand All @@ -18,4 +20,4 @@ service:
traces:
receivers: [otlp]
processors: [batch]
exporters: [logging, jaeger]
exporters: [debug, otlp]
Loading