fix: update references to logging exporter #1178
Conversation
This exporter has been replaced by the debug exporter and will be removed soon Signed-off-by: Alex Boten <[email protected]>
codeboten
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle,
xuan-cao-swi and
a team
as code owners
codeboten
changed the title
There was a problem hiding this comment.
Hi @codeboten!
Thanks for your contribution!
Unfortunately, this repo has similar problems to opentelemetry-ruby, in that it also uses a version of the collector that predates the debug exporter (though this repo uses 0.54.0, rather than 0.35.0).
See this comment on the other PR for more details: open-telemetry/opentelemetry-ruby#1731 (review)
I'd appreciate your help getting things working if you have the time to assist! I imagine the fixes for one of the repos could easily translate to the other.
Signed-off-by: Alex Boten <[email protected]>
|
Updated the example in this repo as well and got a trace in jaeger
Note that I was getting some errors from instrumentations when i ran |
There was a problem hiding this comment.
This works for me too! Good to know about the errors. I didn't see anything that needed immediate attention. Thank you, @codeboten!
| jaeger: | ||
| endpoint: "jaeger:14250" | ||
| otlp: | ||
| endpoint: "jaeger:4317" |
There was a problem hiding this comment.
Should 'jaeger' also be modified here?
There was a problem hiding this comment.
Oh hm, disregard i suppose? Do we need to expose this port on the jaeger container tho? Sorry been a minute since I've peaked at this setup
This exporter has been replaced by the debug exporter and will be removed soon
Related to open-telemetry/opentelemetry-collector#11037