feat: 🦠 Metrics prototype: prepend edition #1129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emit http.server.request.duration metric if the application has the metrics API installed and enables the feature via config
Otherwise it may round to zero
Like the Metrics ConfigurationPatch, include the MetricsPatch modules if Metrics is enabled/present
kaylareopelle
changed the title
kaylareopelle
changed the title
…lle/opentelemetry-ruby-contrib into metrics-alternative-prototype
kaylareopelle
changed the title
kaylareopelle
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
xuan-cao-swi and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd love to get some feedback on this prototype for how we might add metrics to existing instrumentation. There's TODO comments with questions littered throughout the code, please chime in on them.
This prototype follows the pattern in the SDK of patching a class to include certain functionality if the right conditions are met. If the conditions aren't met, no-op methods are defined to glide past them.
In this case, the base gem will look for the presence of the
opentelemetry-metrics-apiin order to create a meter. The instrumentation checks for the:send_metricsconfiguration to be enabled. If it's enabled, metrics will be generated. If not, no-op empty methods will be called instead.The method to add the metric and its attributes is reallly long right now. This is largely for documentation purposes to make it easier to see the currently emitted attributes and their stable equivalents. Once
OTEL_SEMCONV_STABILITY_OPT_INis enabled, this method can be simplified to only emit stable attributes, and, possibly, only emit metrics if the environment variable is set tohttp, the setting to emit stable attributes only.Closes #1127