Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔬 Metrics Prototype: Conditions everywhere edition #1128

Closed
wants to merge 5 commits into from
Closed

🔬 Metrics Prototype: Conditions everywhere edition #1128

wants to merge 5 commits into from

Conversation

kaylareopelle
Copy link
Contributor

A potential way to integrate metrics into the Instrumentation:

  • If the OpenTelemetry::Metrics API is installed, go ahead and make things in base
  • Check for a configuration option, :send_metrics to be true before generating telemetry
  • Still very messy, do we like this general approach?

@kaylareopelle
feat: Add experimental metrics to Rack
2e6b9ab 
Emit http.server.request.duration metric if the application has the
metrics API installed and enables the feature via config
@kaylareopelle
chore: Remove puts
8338fc4
@kaylareopelle
chore: Misc
b031ceb
@kaylareopelle
fix: Make sure duration is a float
d952137 
Otherwise it might round to zero
@kaylareopelle
chore: Add comment, replace view with advice
36854b8
@kaylareopelle kaylareopelle mentioned this pull request Aug 19, 2024
Open
@kaylareopelle
Copy link
Contributor Author

I think this is too clunky. I'm going to put forth #1129 for an in-depth review instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany will be requested when the pull request is marked ready for review fbogsany is a code owner

@mwear mwear Awaiting requested review from mwear mwear will be requested when the pull request is marked ready for review mwear is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin will be requested when the pull request is marked ready for review robertlaurin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma will be requested when the pull request is marked ready for review dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin will be requested when the pull request is marked ready for review ericmustin is a code owner

@arielvalentin arielvalentin Awaiting requested review from arielvalentin arielvalentin will be requested when the pull request is marked ready for review arielvalentin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth will be requested when the pull request is marked ready for review ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam will be requested when the pull request is marked ready for review plantfansam is a code owner

@robbkidd robbkidd Awaiting requested review from robbkidd robbkidd will be requested when the pull request is marked ready for review robbkidd is a code owner

@simi simi Awaiting requested review from simi simi will be requested when the pull request is marked ready for review simi is a code owner

@xuan-cao-swi xuan-cao-swi Awaiting requested review from xuan-cao-swi xuan-cao-swi will be requested when the pull request is marked ready for review xuan-cao-swi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kaylareopelle