Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api-server: update dependencies #913

Merged
merged 42 commits into from
Apr 24, 2024
Merged

api-server: update dependencies #913

merged 42 commits into from
Apr 24, 2024

Conversation

koonpeng
Copy link
Collaborator

@koonpeng koonpeng commented Mar 13, 2024

What's new

uvicorn changed the behavior of handling root_path, after we updated fastapi, it assumes the new uvicorn behavior which causes things to fail when behind a proxy.

What started out as a update to uvicorn turns into updating most dependencies in api_server as new uvicorn broke tortoise-orm, and new tortoise-orm broke pydantic etc.

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 63.00000% with 148 lines in your changes are missing coverage. Please review.

Project coverage is 49.77%. Comparing base (300b34e) to head (08c80bc).

❗ Current head 08c80bc differs from pull request most recent head 8820c85. Consider uploading reports for the commit 8820c85 to get more accurate results

Files Patch % Lines
...server/api_server/models/rmf_api/rtls_tag_state.py 0.00% 31 Missing ⚠️
...ages/dashboard/src/components/tasks/task-alert.tsx 0.00% 10 Missing ⚠️
...kages/dashboard/src/components/tasks/task-logs.tsx 16.66% 10 Missing ⚠️
...ver/api_server/models/rmf_api/transformation_2D.py 0.00% 9 Missing ⚠️
...-server/api_server/routes/tasks/scheduled_tasks.py 57.89% 8 Missing ⚠️
...rver/models/rmf_ros2/event_description_Sequence.py 0.00% 7 Missing ⚠️
...ckages/api-server/api_server/routes/tasks/tasks.py 65.00% 7 Missing ⚠️
...ges/api-server/api_server/models/rmf_ros2/Place.py 0.00% 6 Missing ⚠️
...ckages/api-server/api_server/rmf_io/book_keeper.py 16.66% 5 Missing ⚠️
.../dashboard/src/components/robots/robot-summary.tsx 0.00% 5 Missing ⚠️
... and 20 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #913      +/-   ##
==========================================
- Coverage   50.48%   49.77%   -0.71%     
==========================================
  Files         283      286       +3     
  Lines        7179     7258      +79     
  Branches      981      983       +2     
==========================================
- Hits         3624     3613      -11     
- Misses       3407     3499      +92     
+ Partials      148      146       -2     
Flag Coverage Δ
dashboard 16.60% <6.12%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koonpeng koonpeng changed the title api-server: update uvicorn api-server: update dependencies Mar 18, 2024
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
@koonpeng
Copy link
Collaborator Author

@aaronchongth pnpm has just dropped support for node16, we should get this merged asap.

Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you modify the README to set up with node 20? I'll test the changes so we can move forward for main while we work on the upcoming new main branch

@aaronchongth aaronchongth merged commit e3d2b1c into main Apr 24, 2024
5 checks passed
@aaronchongth aaronchongth deleted the kp/update-uvicorn branch April 24, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants