[BB-8929] fix: remove redundant form-control class for MasqueradeUserNameInput #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the FormControl element already comes with the form-control class, the extra class specified on the MasqueradeUserInput is applied to the div container of the <input> causing double input box effect. This is not visible in themes where the container div's padding is zero. But appears when padding is not set. Internal-ref: https://tasks.opencraft.com/browse/BB-8929
tecoholic
changed the title
|
@viadanna The CI seems to be failing on an unrelated file to this PR. I noticed it failing while committing as well. Kindly let me know if I should handle the error as well. |
viadanna
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the FormControl element already comes with the form-control class, the extra class specified on the MasqueradeUserInput is applied to the div container of the causing double input box effect. This is not visible in themes where the container div's padding is zero. But appears when padding is not set.
Internal-ref: https://tasks.opencraft.com/browse/BB-8929
Note about upstreaming the changes
An upstream PR for this
is not requiredmay not be necessary, as upstream hasedx/paragontoopenedx/paragonMasqueradeUserNameInput.jsxnow uses theInputcomponent instead of theFormControlcomponent which doesn't render an extra div around the element.Yet, I have created a PR with the same changes at: openedx#1416
UI Changes
Before
After