fix: remove redundant form-control in masquerade user input

[tecoholic]

Description

This PR just removes a redundant class from the code. There are no UI changes in the master version as the same class is applied to twice. This was causing an issue in the previous versions which are using the @edx/paragon and FormControl in the MasqueradeUserNameInput (Ref: see open-craft#24).

Since master branch uses @openedx/paragon and Input in the MasqueradeUserNameInput component, the styles don't really cause any UI issues and it is just a minor improvement in code quality.

Changes

Before

After

[openedx-webhooks]

Thanks for the pull request, @tecoholic!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-aurora. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.83%. Comparing base (c7a81fe) to head (9a52729).
Report is 8 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1416   +/-   ##
=======================================
  Coverage   88.83%   88.83%           
=======================================
  Files         307      307           
  Lines        5268     5268           
  Branches     1338     1338           
=======================================
  Hits         4680     4680           
  Misses        572      572           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[itsjeyd]

@tecoholic Is this waiting for OpenCraft internal review or did you want to send it straight to upstream review?

[tecoholic]

@itsjeyd I have pinged @farhaanbukhsh internally to take a look at this. However, I wasn't certain if he has CC access to this repo at that time. The CC list indicates there are no CCs from OpenCraft who have access.

This PR was a side effect of an internal ticket and, as such, doesn't fix anything. So, I would like to get an upstream review directly if possible.

[farhaanbukhsh]

Hey @tecoholic I am not a CC/maintainer for the repo :) from backstage I can see that 2u-aurora maintains it.

[itsjeyd]

@tecoholic Got it, I'll mark this as ready for review now.

@farhaanbukhsh @tecoholic The Aurora team is stepping down as maintainer and most likely won't be reviewing this PR.

@feanil @arbrandes @brian-smith-tcril Would one of you be able to help us get this tiny change over the line?

[feanil]

Change looks good and tested locally just fine.

[openedx-webhooks]

@tecoholic 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

[itsjeyd]

Thanks a lot @feanil.