account.get_utxo pagination #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o ddos-account-utxo
InoMurko
approved these changes
Apr 7, 2020
achiurizo
approved these changes
Apr 13, 2020
unnawut
reviewed
Apr 14, 2020
|
|
||
| Repo.all(query) | ||
| @spec get_utxos(keyword) :: OMG.Utils.Paginator.t() | ||
| def get_utxos(params) do |
There was a problem hiding this comment.
Very clean refactor. I like!
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| defmodule OMG.WatcherRPC.Web.Validator.AccountConstraints do |
| @@ -0,0 +1,5 @@ | |||
| Feature: Watcher info | |||
|
|
|||
| Scenario: Alice want to use watcher info api | |||
There was a problem hiding this comment.
Not updated yet I think, so un-resolving...
unnawut
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1274
Overview
Add pagination for account.get_utxos
Changes
Describe your changes and implementation choices. More details make PRs easier to review.
account.get_utxoto acceptpageandlimitTesting