Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Dos on account.get_utxo because it doesn't have limit #1274

Closed
jarindr opened this issue Jan 22, 2020 · 4 comments
Closed

Potential Dos on account.get_utxo because it doesn't have limit #1274

jarindr opened this issue Jan 22, 2020 · 4 comments
Assignees

Comments

@jarindr
Copy link
Contributor

jarindr commented Jan 22, 2020

account.get_utxo endpoint doesn't have limit on numbers of items returned. this can break the whole watcher when get dos on an account that has high number of utxo

@kevsul kevsul transferred this issue from another repository Jan 22, 2020
@unnawut
Copy link
Contributor

unnawut commented Jan 22, 2020

Relates to #1257

Edit: relates in the sense that fixing this issue, the other issue regarding utxos retrieval is still remaining to be fixed.

@pnowosie
Copy link
Contributor

IMHO there is no link between #1257 and this #1274, info’s get_utxos and security’s get_exitable_utxo are different endpoints

@unnawut
Copy link
Contributor

unnawut commented Mar 25, 2020

IMHO there is no link between #1257 and this #1274, info’s get_utxos and security’s get_exitable_utxo are different endpoints

Ah sorry I didn't put why I thought they're related. Yup agree that they're different endpoints.

The only relation is that the discussions that took place were on utxos retrieval but there are actually 2 separate places to fix. So adding a relation here so we don't mistake fixing only one issue being "the utxos retrieval issue is solved"

I've added this reasoning to my old comment above. Thanks!

@unnawut
Copy link
Contributor

unnawut commented Apr 17, 2020

Fixed by #1436

@unnawut unnawut closed this as completed Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants