Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCTOPUS-625:Added playbook vars files #16

Merged
merged 2 commits into from
Mar 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions openstack/intel-worker/playbooks/intel-worker-cleanup-playbook.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
---
- name: Intel worker vitrual_machine delete
roles:
- vm-delete
- name: OpenStack worker node configuration Tasks
hosts: all
tasks:
- name: Intel worker vitrual_machine delete

Check failure on line 5 in openstack/intel-worker/playbooks/intel-worker-cleanup-playbook.yml

View workflow job for this annotation

GitHub Actions / Ansible Lint

syntax-check[specific]

unexpected parameter type in action: <class 'ansible.parsing.yaml.objects.AnsibleSequence'>
roles:
- vm-delete

- name: Intel worker flavor create
roles:
- flavor-delete
- name: Intel worker flavor create
roles:
- flavor-delete

- name: Create RHCHOS image
hosts: all
roles:
- rhcos-image-delete
- name: Create RHCHOS image
hosts: all
roles:
- rhcosImage-delete
40 changes: 21 additions & 19 deletions openstack/intel-worker/playbooks/intel-worker-playbook.yml
Original file line number Diff line number Diff line change
@@ -1,25 +1,27 @@
---
- name: Create RHCHOS image
- name: OpenStack worker node configuration Tasks
hosts: all
roles:
- rhcosImage-create
tasks:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ansible warning... unexpected parameter type in action: <class 'ansible.parsing.yaml.objects.AnsibleSequence'>

I'm wondering if we need something changed here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to make some changes here , even in the doc , I did not get what's wrong here , there is no proper explanation why it's wrong .

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! that makes sense to me... thanks for checking

- name: Create RHCHOS image

Check failure on line 5 in openstack/intel-worker/playbooks/intel-worker-playbook.yml

View workflow job for this annotation

GitHub Actions / Ansible Lint

syntax-check[specific]

unexpected parameter type in action: <class 'ansible.parsing.yaml.objects.AnsibleSequence'>
roles:
- rhcosImage-create

- name: Intel worker flavor create
roles:
- flavor-create
- name: Intel worker flavor create
roles:
- flavor-create

- name: Intel worker vitrual_machine create
roles:
- vm-create
- name: Intel worker vitrual_machine create
roles:
- vm-create

- name: Intel worker vitrual_machine create
roles:
- vm-server-action
vars:
virtual_machine_server_action: "stop"
- name: Intel worker vitrual_machine create
roles:
- vm-server-action
vars:
virtual_machine_server_action: stop

- name: Intel worker vitrual_machine create
roles:
- vm-server-action
vars:
virtual_machine_server_action: "start"
- name: Intel worker vitrual_machine create
roles:
- vm-server-action
vars:
virtual_machine_server_action: start
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---

# Image details centos
image_name_centos: Centos9_img
image_container_format_centos: bare
image_disk_format_centos: qcow2
image_dest_filename_centos: /tmp/CentOS-Stream-GenericCloud-9-20230327.0.x86_64.qcow2
image_is_public_centos: true
image_url_centos: https://cloud.centos.org/centos/9-stream/x86_64/images/CentOS-Stream-GenericCloud-9-20230327.0.x86_64.qcow2
image_cpu_arch_centos: x86_64
image_distro_centos: rhel
image_validate_certs_centos: false
Original file line number Diff line number Diff line change
@@ -1,27 +1,21 @@
---
- name: OpenStack worker node configuration Tasks (i.e. Create worker.ign, Upload RHCOS Image, Create Customization Script, Create Instance etc)
hosts: all
vars_files:
- ../../../../vars/main.yml
- name: Download the Image from the URL and use to create image
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about kebab case so we follow a consistent role?
centosImage-create we should change to centos-image-create

we'd update rhcos too. I think we can leave this for the next PR (if it makes sense)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes , I thought to have centos-image-create , but ansible-lint was giving me error for this name with twice - in the name , so because of this , thought to name it as centosImage-create .

ansible.builtin.get_url:
url: "{{ image_url_centos }}"
dest: "{{ image_dest_filename_centos }}"
mode: "0755"
validate_certs: "{{ image_validate_certs_centos }}"
register: image_download_stats

tasks:
- name: Download the Image from the URL and use to create image
ansible.builtin.get_url:
url: "{{ image_url_centos }}"
dest: "{{ image_dest_filename_centos }}"
mode: '0755'
validate_certs: "{{ image_validate_certs_centos }}"
register: image_download_stats

- name: Create/upload Centos images to openstack.
openstack.cloud.image:
cloud: openstack
state: present
name: "{{ image_name_centos_centos }}"
container_format: "{{ image_container_format_centos }}"
disk_format: "{{ image_disk_format_centos }}"
filename: "{{ image_dest_filename_centos }}"
is_public: "{{ image_is_public_centos }}"
properties:
cpu_arch: "{{ image_cpu_arch_centos }}"
distro: "{{ image_distro_centos }}"
- name: Create/upload Centos images to openstack.

Check failure on line 10 in openstack/intel-worker/playbooks/roles/centosImage-create/tasks/main.yml

View workflow job for this annotation

GitHub Actions / Ansible Lint

syntax-check[unknown-module]

couldn't resolve module/action 'openstack.cloud.image'. This often indicates a misspelling, missing collection, or incorrect module path.
openstack.cloud.image:
cloud: openstack
state: present
name: "{{ image_name_centos_centos }}"
container_format: "{{ image_container_format_centos }}"
disk_format: "{{ image_disk_format_centos }}"
filename: "{{ image_dest_filename_centos }}"
is_public: "{{ image_is_public_centos }}"
properties:
cpu_arch: "{{ image_cpu_arch_centos }}"
distro: "{{ image_distro_centos }}"
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---

# Image details centos
image_name_centos: Centos9_img
image_container_format_centos: bare
image_disk_format_centos: qcow2
image_is_public_centos: true
image_cpu_arch_centos: x86_64
image_distro_centos: rhel
Original file line number Diff line number Diff line change
@@ -1,17 +1,11 @@
---
- name: OpenStack worker node configuration Tasks (i.e. Create worker.ign, Upload RHCOS Image, Create Customization Script, Create Instance etc)
hosts: all
vars_files:
- ../../../../vars/main.yml

tasks:
- name: Remove Centos images to openstack.
openstack.cloud.image:
cloud: openstack
state: absent
name: "{{ image_name_centos }}"
disk_format: "{{ image_disk_format_centos }}"
is_public: "{{ image_is_public_centos }}"
properties:
cpu_arch: "{{ image_cpu_arch_centos }}"
distro: "{{ image_distro_centos }}"
- name: Remove Centos images to openstack.

Check failure on line 2 in openstack/intel-worker/playbooks/roles/centosImage-delete/tasks/main.yml

View workflow job for this annotation

GitHub Actions / Ansible Lint

syntax-check[unknown-module]

couldn't resolve module/action 'openstack.cloud.image'. This often indicates a misspelling, missing collection, or incorrect module path.
openstack.cloud.image:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we need to add e requirements.yaml #17 it might clean up the warning.

cloud: openstack
state: absent
name: "{{ image_name_centos }}"
disk_format: "{{ image_disk_format_centos }}"
is_public: "{{ image_is_public_centos }}"
properties:
cpu_arch: "{{ image_cpu_arch_centos }}"
distro: "{{ image_distro_centos }}"
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
# Custom flavor details
custom_flavor_name: rdr_mac_8vcpu_16ram
custom_flavor_ram: 16
custom_flavor_vcpus: 8
custom_flavor_disk: 80
custom_flavor_ephemeral: 80
custom_flavor_description: custom flavour for mac intel worker 8 vcpu and 16gb ram
26 changes: 10 additions & 16 deletions openstack/intel-worker/playbooks/roles/flavor-create/tasks/main.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,11 @@
---
- name: OpenStack worker node configuration Tasks (i.e. Create worker.ign, Upload RHCOS Image, Create Customization Script, Create Instance etc)
hosts: all
vars_files:
- ../../../../vars/main.yml

tasks:
- name: Create flavor to openstack
openstack.cloud.compute_flavor:
cloud: openstack
state: present
name: "{{ custom_flavor_name }}"
ram: "{{ custom_flavor_ram }}"
vcpus: "{{ custom_flavor_vcpus }}"
disk: "{{ custom_flavor_disk }}"
ephemeral: "{{ custom_flavor_ephemeral }}"
description: "{{ custom_flavor_description }}"
- name: Create flavor to openstack

Check failure on line 2 in openstack/intel-worker/playbooks/roles/flavor-create/tasks/main.yml

View workflow job for this annotation

GitHub Actions / Ansible Lint

syntax-check[unknown-module]

couldn't resolve module/action 'openstack.cloud.compute_flavor'. This often indicates a misspelling, missing collection, or incorrect module path.
openstack.cloud.compute_flavor:
cloud: openstack
state: present
name: "{{ custom_flavor_name }}"
ram: "{{ custom_flavor_ram }}"
vcpus: "{{ custom_flavor_vcpus }}"
disk: "{{ custom_flavor_disk }}"
ephemeral: "{{ custom_flavor_ephemeral }}"
description: "{{ custom_flavor_description }}"
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
# Custom flavor details
custom_flavor_name: rdr_mac_8vcpu_16ram
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
---
- name: OpenStack worker node configuration Tasks (i.e. Create worker.ign, Upload RHCOS Image, Create Customization Script, Create Instance etc)
hosts: all
vars_files:
- ../../../../vars/main.yml

tasks:
- name: Remove flavor from openstack
openstack.cloud.compute_flavor:
cloud: openstack
state: absent
name: "{{ custom_flavor_name }}"
- name: Remove flavor from openstack

Check failure on line 2 in openstack/intel-worker/playbooks/roles/flavor-delete/tasks/main.yml

View workflow job for this annotation

GitHub Actions / Ansible Lint

syntax-check[unknown-module]

couldn't resolve module/action 'openstack.cloud.compute_flavor'. This often indicates a misspelling, missing collection, or incorrect module path.
openstack.cloud.compute_flavor:
cloud: openstack
state: absent
name: "{{ custom_flavor_name }}"
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
# Host aggregate details
host_aggregate_name: multi-arch-compute-aggregate
host_availability_zone_name: multi-arch-aggregate
host_name_list: [<host1>, <host2>, <host3>]
# Examples:
# host_name_list: ["xcloud8", "xcloud7", "xcloud10"]
Original file line number Diff line number Diff line change
@@ -1,15 +1,9 @@
---
- name: OpenStack worker node configuration Tasks (i.e. Create worker.ign, Upload RHCOS Image, Create Customization Script, Create Instance etc)
hosts: all
vars_files:
- ../../../../vars/main.yml

tasks:
- name: Create host aggregate (host group) to openstack
openstack.cloud.host_aggregate:
cloud: openstack
state: present
name: "{{ host_aggregate_name }}"
hosts: "{{ host_name_list }}"
metadata:
availability_zone: "{{ host_availability_zone_name }}"
- name: Create host aggregate (host group) to openstack

Check failure on line 2 in openstack/intel-worker/playbooks/roles/host-aggregate-create/tasks/main.yml

View workflow job for this annotation

GitHub Actions / Ansible Lint

syntax-check[unknown-module]

couldn't resolve module/action 'openstack.cloud.host_aggregate'. This often indicates a misspelling, missing collection, or incorrect module path.
openstack.cloud.host_aggregate:
cloud: openstack
state: present
name: "{{ host_aggregate_name }}"
hosts: "{{ host_name_list }}"
metadata:
availability_zone: "{{ host_availability_zone_name }}"
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
# Host aggregate details
host_aggregate_name: multi-arch-compute-aggregate
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
---
- name: OpenStack worker node configuration Tasks (i.e. Create worker.ign, Upload RHCOS Image, Create Customization Script, Create Instance etc)
hosts: all
vars_files:
- ../../../../vars/main.yml

tasks:
- name: Remove host aggregate (host group) from openstack
openstack.cloud.host_aggregate:
cloud: openstack
state: absent
name: "{{ host_aggregate_name }}"
- name: Remove host aggregate (host group) from openstack

Check failure on line 2 in openstack/intel-worker/playbooks/roles/host-aggregate-delete/tasks/main.yml

View workflow job for this annotation

GitHub Actions / Ansible Lint

syntax-check[unknown-module]

couldn't resolve module/action 'openstack.cloud.host_aggregate'. This often indicates a misspelling, missing collection, or incorrect module path.
openstack.cloud.host_aggregate:
cloud: openstack
state: absent
name: "{{ host_aggregate_name }}"
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
# Image details Rhcos
image_name_rhcos: RHCOS_img
image_container_format_rhcos: bare
image_disk_format_rhcos: qcow2
image_dest_filename_rhcos: /tmp/rhcos-openstack.x86_64.qcow2.gz
image_is_public_rhcos: true
image_url_rhcos: https://mirror.openshift.com/pub/openshift-v4/x86_64/dependencies/rhcos/latest/rhcos-openstack.x86_64.qcow2.gz
image_cpu_arch_rhcos: x86_64
image_distro_rhcos: rhel
image_validate_certs_rhcos: false
Original file line number Diff line number Diff line change
@@ -1,27 +1,21 @@
---
- name: OpenStack worker node configuration Tasks (i.e. Create worker.ign, Upload RHCOS Image, Create Customization Script, Create Instance etc)
hosts: all
vars_files:
- ../../../../vars/main.yml
- name: Download the Image from the URL and use to create image
ansible.builtin.get_url:
url: "{{ image_url_rhcos }}"
dest: "{{ image_dest_filename_rhcos }}"
mode: "0755"
validate_certs: "{{ image_validate_certs_rhcos }}"
register: image_download_stats

tasks:
- name: "Download the Image from the URL and use to create image"
ansible.builtin.get_url:
url: "{{ image_url_rhcos }}"
dest: "{{ image_dest_filename_rhcos }}"
mode: '0755'
validate_certs: "{{ image_validate_certs_rhcos }}"
register: image_download_stats

- name: Create/upload RHCOS images to openstack.
openstack.cloud.image:
cloud: openstack
state: present
name: "{{ image_name_rhcos }}"
container_format: "{{ image_container_format_rhcos }}"
disk_format: "{{ image_disk_format_rhcos }}"
filename: "{{ image_dest_filename_rhcos }}"
is_public: "{{ image_is_public_rhcos }}"
properties:
cpu_arch: "{{ image_cpu_arch_rhcos }}"
distro: "{{ image_distro_rhcos }}"
- name: Create/upload RHCOS images to openstack.

Check failure on line 10 in openstack/intel-worker/playbooks/roles/rhcosImage-create/tasks/main.yml

View workflow job for this annotation

GitHub Actions / Ansible Lint

syntax-check[unknown-module]

couldn't resolve module/action 'openstack.cloud.image'. This often indicates a misspelling, missing collection, or incorrect module path.
openstack.cloud.image:
cloud: openstack
state: present
name: "{{ image_name_rhcos }}"
container_format: "{{ image_container_format_rhcos }}"
disk_format: "{{ image_disk_format_rhcos }}"
filename: "{{ image_dest_filename_rhcos }}"
is_public: "{{ image_is_public_rhcos }}"
properties:
cpu_arch: "{{ image_cpu_arch_rhcos }}"
distro: "{{ image_distro_rhcos }}"
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
# Image details Rhcos
image_name_rhcos: RHCOS_img
image_container_format_rhcos: bare
image_disk_format_rhcos: qcow2
image_cpu_arch_rhcos: x86_64
image_distro_rhcos: rhel
Original file line number Diff line number Diff line change
@@ -1,17 +1,11 @@
---
- name: OpenStack worker node configuration Tasks (i.e. Create worker.ign, Upload RHCOS Image, Create Customization Script, Create Instance etc)
hosts: all
vars_files:
- ../../../../vars/main.yml

tasks:
- name: Remove RHCOS images from openstack.
openstack.cloud.image:
cloud: openstack
state: absent
name: "{{ image_name_rhcos }}"
disk_format: "{{ image_disk_format_rhcos }}"
is_public: "{{ image_is_public_rhcos }}"
properties:
cpu_arch: "{{ image_cpu_arch_rhcos }}"
distro: "{{ image_distro_rhcos }}"
- name: Remove RHCOS images from openstack.

Check failure on line 2 in openstack/intel-worker/playbooks/roles/rhcosImage-delete/tasks/main.yml

View workflow job for this annotation

GitHub Actions / Ansible Lint

syntax-check[unknown-module]

couldn't resolve module/action 'openstack.cloud.image'. This often indicates a misspelling, missing collection, or incorrect module path.
openstack.cloud.image:
cloud: openstack
state: absent
name: "{{ image_name_rhcos }}"
disk_format: "{{ image_disk_format_rhcos }}"
is_public: "{{ image_is_public_rhcos }}"
properties:
cpu_arch: "{{ image_cpu_arch_rhcos }}"
distro: "{{ image_distro_rhcos }}"
Loading